Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix MavenITmng7836AlternativePomSyntaxTest #307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slawekjaranowski
Copy link
Member

No description provided.

@slawekjaranowski
Copy link
Member Author

This patch make a build green https://github.com/apache/maven/actions/runs/6318762268
but not resolve a problem

@gnodet
Copy link
Contributor

gnodet commented Sep 27, 2023

The fix is #308.
The problem occurred because I split some PRs. Each PR was individually passing the tests, but when both had been merged, the test from the first PR was broken by the second PR.

</snapshots>
</pluginRepository>
</pluginRepositories>
</profile>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those should not be needed.
IIUC, this should already be fixed by apache/maven@f24266e#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fix only build on GitHub teh same local repo is used for build Maven and execute IT
but on jenkins and on local host we have separate clean repo for ITs

@slawekjaranowski
Copy link
Member Author

Master build is still suffer from it ... do we have any other idea - how to fix
After release alpha-8 we will can remove access to remote repo and move needed artifacts to bootstrap.

@gnodet
Copy link
Contributor

gnodet commented Oct 4, 2023

Master build is still suffer from it ... do we have any other idea - how to fix After release alpha-8 we will can remove access to remote repo and move needed artifacts to bootstrap.

I still think we should run the integration tests on a locally build distribution, else there's no way we can test something depending on new code in maven. So for the time being, I would either disable the test until alpha-8 is released or build Maven snapshot locally (or disable Jenkins jobs which are the only one failing).

@slawekjaranowski
Copy link
Member Author

Master build is still suffer from it ... do we have any other idea - how to fix After release alpha-8 we will can remove access to remote repo and move needed artifacts to bootstrap.

I still think we should run the integration tests on a locally build distribution, else there's no way we can test something depending on new code in maven. So for the time being, I would either disable the test until alpha-8 is released or build Maven snapshot locally (or disable Jenkins jobs which are the only one failing).

We run test on current build distribution:

Running integration tests for Maven 4.0.0-alpha-8-SNAPSHOT
	using Maven executable: /home/jenkins/jenkins-home/workspace/Maven_maven-box_maven_MNG-7898/test/core-it-suite/target/apache-maven/bin/mvn
	with verifier.forkMode: auto

We only don't have populated local repo used by test by Maven build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants