-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix MavenITmng7836AlternativePomSyntaxTest #307
base: master
Are you sure you want to change the base?
Conversation
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7836AlternativePomSyntaxTest.java
Outdated
Show resolved
Hide resolved
This patch make a build green https://github.com/apache/maven/actions/runs/6318762268 |
The fix is #308. |
</snapshots> | ||
</pluginRepository> | ||
</pluginRepositories> | ||
</profile> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those should not be needed.
IIUC, this should already be fixed by apache/maven@f24266e#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fix only build on GitHub teh same local repo is used for build Maven and execute IT
but on jenkins and on local host we have separate clean repo for ITs
e3b4f31
to
00fd173
Compare
Master build is still suffer from it ... do we have any other idea - how to fix |
I still think we should run the integration tests on a locally build distribution, else there's no way we can test something depending on new code in maven. So for the time being, I would either disable the test until alpha-8 is released or build Maven snapshot locally (or disable Jenkins jobs which are the only one failing). |
We run test on current build distribution:
We only don't have populated local repo used by test by Maven build |
No description provided.