Use 4.0.99 as as intermediate model to keep 4.1.0 for the Maven 4.x model #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
approved these changes
Nov 6, 2023
kwin
reviewed
Nov 6, 2023
| @@ -387,7 +388,7 @@ | |||
| </fields> | |||
| <codeSegments> | |||
| <codeSegment> | |||
| <version>4.0.0/4.1.0</version> | |||
| <version>4.0.0/4.0.99</version> | |||
There was a problem hiding this comment.
@gnodet What is this supposed to mean?
There was a problem hiding this comment.
This is closed ranged version notation. That's defined by modello...
There was a problem hiding this comment.
Ah, sorry. I get it now. I thought this element was for documentation purposes
There was a problem hiding this comment.
Sadly, modello "version range" predates (AFAIK, someone may correct me) Maven ranges, and has totally different syntax...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix model doc generation, change the intermediate model to use 4.0.99 and align the new model to 4.1.0
This requires apache/maven-integration-testing#315 to pass ITs...