Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8258] Change the fixed reproducible build outputTimestamp to 1 Feb 1980 #1813

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

stokito
Copy link
Contributor

@stokito stokito commented Oct 17, 2024

JIRA Issue: MNG-8258
IT PR: apache/maven-integration-testing#392


The Maven used the own inception year 2001.
But the Gradle already use the 1 Feb 1980 for preserveFileTimestamps.

The 1 Jan 1980 is a minimal date in Zip archive but the 1 Jan has some special treatment by Java that's why the Gradle team used the 1 Feb.

See more detailed description in CONSTANT_TIME_FOR_ZIP_ENTRIES https://github.com/gradle/gradle/blob/master/platforms/core-runtime/files/src/main/java/org/gradle/api/internal/file/archive/ZipEntryConstants.java#L39

The change was first proposed in the #1726 (comment) and also slightly discussed in the MSHARED-1430

@hboutemy:
many people have many opinions: there are even more opinions than people
The default value has been added in MNG-8258 with a Maven-specific timestamp (no reason to try to mimic others: there is no perfect or wrong choice)
@stokito:
Sure, but a standardization always improves and simplifies things (if done right). Having the same value 1 Feb 1980 will simplify search "Why my jar has the weird date? You have the reproducible build. Ah, ok, ty". But also I switch from Gradle to Maven then if would be less differences in artifacts.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…eb 1980

The Maven used the year 2001 (beginning of 21st century).
But the Gradle already use the 1 Feb 1980 for preserveFileTimestamps.

The 1 Jan 1980 is a minimal date in Zip archive but the 1 Jan has some special treatment by Java that's why the Gradle team used the 1 Feb.

See more detailed description in CONSTANT_TIME_FOR_ZIP_ENTRIES
https://github.com/gradle/gradle/blob/master/platforms/core-runtime/files/src/main/java/org/gradle/api/internal/file/archive/ZipEntryConstants.java#L39

Signed-off-by: Sergey Ponomarev <[email protected]>
@mthmulders mthmulders changed the title [MNG-8258] Change the fixed reproducible build outputTimestamp to 1 Feb 1080 [MNG-8258] Change the fixed reproducible build outputTimestamp to 1 Feb 1980 Oct 17, 2024
@gnodet gnodet added this to the 4.0.0-beta-5 milestone Oct 17, 2024
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gnodet gnodet merged commit 989f798 into apache:master Oct 17, 2024
13 checks passed
@stokito stokito deleted the feature/MNG-8258 branch October 17, 2024 15:18
@stokito
Copy link
Contributor Author

stokito commented Oct 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants