Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commons-compress dependecy on commons-codec and commons-lang3 was missing #7816

Merged

Conversation

matthiasblaesing
Copy link
Contributor

Closes: #7814

@matthiasblaesing matthiasblaesing added Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Oct 1, 2024
@matthiasblaesing matthiasblaesing added this to the NB24 milestone Oct 1, 2024
@matthiasblaesing matthiasblaesing requested a review from mbien October 1, 2024 19:14
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, commons-compress seems to have three non-optional compile time dependencies: codec, io and lang3

$ mvn eu.maveniverse.maven.plugins:toolbox:gav-tree -Dgav=org.apache.commons:commons-compress:1.26.2
[INFO] org.apache.commons:commons-compress:jar:1.26.2
[INFO] ├─com.github.luben:zstd-jni:jar:1.5.6-3 [compile, optional]
[INFO] ├─org.brotli:dec:jar:0.1.2 [compile, optional]
[INFO] ├─org.tukaani:xz:jar:1.9 [compile, optional]
[INFO] ├─commons-codec:commons-codec:jar:1.17.0 [compile]
[INFO] ├─org.ow2.asm:asm:jar:9.7 [compile, optional]
[INFO] ├─commons-io:commons-io:jar:2.16.1 [compile]
[INFO] ╰─org.apache.commons:commons-lang3:jar:3.14.0 [compile]

@matthiasblaesing
Copy link
Contributor Author

@mbien yeah, I had a look at the module-info.class ;-). Thanks.

@matthiasblaesing matthiasblaesing merged commit bc6aea9 into apache:master Oct 1, 2024
32 checks passed
@neilcsmith-net
Copy link
Member

Yes, commons-lang3 and commons-io came in with 1.26.0, and commons-codec became non-optional in 1.26.1 AFAIK. This should have been picked up in #7237 We had some minor release issues with NBPackage with merge of apache/netbeans-nbpackage#49 too. At least there the transitive dependencies are brought in. For NetBeans we could really do with making sure we find a way to highlight dependency updates in libs. @mbien how "easy" to do a diff of transitive dependencies as part of https://github.com/apache/netbeans/blob/master/.github/scripts/BinariesListUpdates.java ?

@mbien
Copy link
Member

mbien commented Oct 2, 2024

well, right now it runs in java and simply uses the maven central search to query versions. To get the dependency tree, this would have to use more external libs which would also require to resolve every single dependency (might be very slow and potentially be throttled by the service).

Not sure how I would do this, potentially even in bash + maven toolbox, otherwise this might end up being a larger program and no longer a "script".

Also: I am not sure if anyone outside of me is actually using this. I also asked myself the question while toying with #6630

@mbien
Copy link
Member

mbien commented Oct 2, 2024

btw the very first version of this (which I never committed), generated a gigantic pom and ran the version check plugin on it -> this might be also an approach to take since this could run more plugins.

@matthiasblaesing matthiasblaesing deleted the fix_commons_compress branch October 2, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when trying to download Node.js sources 20.17.0
3 participants