Action for running tests in parallel #7979
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java
MartinBalin
requested review from
dbalek,
lahodaj,
sdedic and
lkishalmi
and removed request for
lahodaj
sdedic
requested changes
Nov 30, 2024
extide/gradle/src/org/netbeans/modules/gradle/ActionProviderImpl.java
Outdated
Show resolved
Hide resolved
ide/extexecution.base/src/org/netbeans/api/extexecution/base/ExplicitProcessParameters.java
Outdated
Show resolved
Hide resolved
...a.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/launch/NbLaunchDelegate.java
Outdated
Show resolved
Hide resolved
java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
Show resolved
Hide resolved
java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/execute/AbstractOutputHandler.java
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
Outdated
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineOptions.java
Outdated
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/execute/cmd/ExecMojo.java
Outdated
Show resolved
Hide resolved
java/maven/src/org/netbeans/modules/maven/execute/model/NetbeansActionMapping.java
Show resolved
Hide resolved
sdedic
added
API Change
sdedic
reviewed
Dec 4, 2024
ide/projectapi/src/org/netbeans/spi/project/ContainedProjectFilter.java
Outdated
Show resolved
Hide resolved
| import org.netbeans.api.project.Project; | ||
|
|
||
| /** | ||
| * |
There was a problem hiding this comment.
Pls. include some class overview and a description of an example usage (i.e. action acting on several projects may use this to filter). Should be noted that usage is optional and decided by individual actions and must be documented with the action.
I see that in the implementation an empty ContentProjectFilter is treated as no filter; hypotetically (since this is an API) - is there a way how to express that an action working with this selector should operate on the project itself, not any of its children ?
There was a problem hiding this comment.
Well, we can introduce filterMode, which would be filled depending on the list size?
java/gradle.test/src/org/netbeans/modules/gradle/test/GradleTestProgressListener.java
Outdated
Show resolved
Hide resolved
| if (project == null) { | ||
| return null; | ||
| } | ||
| return Paths.get(project.getProjectDirectory().getPath(), "src", "test", "java").toString(); |
There was a problem hiding this comment.
Not sure about this -- @dbalek: shouldn't we rather use Sources API to get java/test source group and its folder from the project ?
java/maven/src/org/netbeans/modules/maven/execute/MavenCommandLineExecutor.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/ModuleInfo.java
Outdated
Show resolved
Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/progress/TestProgressHandler.java
Outdated
Show resolved
Hide resolved
| if (project == null) { | ||
| return null; | ||
| } | ||
| return Paths.get(project.getProjectDirectory().getPath(), "src", "test", "java").toString(); |
There was a problem hiding this comment.
similar for the usage of Source API - whatever decision is taken.
| @@ -132,6 +132,7 @@ public class ActionProviderImpl implements ActionProvider { | |||
| "javadoc", //NOI18N | |||
| COMMAND_TEST, | |||
| COMMAND_TEST_SINGLE, | |||
| COMMAND_TEST_PARALLEL, | |||
There was a problem hiding this comment.
bump dependency version on project.api
petrovic-d
force-pushed
the
action-for-running-tests-in-parallel
branch
from
d717d00
to
a8c4d23
Compare
neilcsmith-net
previously requested changes
Dec 4, 2024
petrovic-d
force-pushed
the
action-for-running-tests-in-parallel
branch
from
c3ae922
to
54b4326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New action for running tests in parallel. It can be invoked via command:
nbls.run.test.parallelCommand support specifying modules for which tests will be ran in parallel. It's up to client to pass the module list, so by default it will run without passed modules.
To test it with module list, it needs to be modified like this:
in
java/java.lsp.server/vscode/src/extension.tsfilemodify line
835to:testAdapter?.run(new vscode.TestRunRequest(), new vscode.CancellationTokenSource().token, true, ["module1", "module2"]);