Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to JDK 24b27. #8037

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Dec 11, 2024

A first sketch (so far) to attempt to (nb-)javac from JDK 24.

@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests labels Dec 11, 2024
@lahodaj lahodaj added this to the NB25 milestone Dec 11, 2024
Object ordinary = null;

try {
ordinary = Enum.valueOf((Class<Enum>) Class.forName("com.sun.tools.javac.api.JavacScope$ScopeType"), "ORDINARY");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ScopeType is currently private in JavacScope. I'll see if there's something that can be done about it, but it seems somewhat unlikely it could be done in JDK24. So it seems we may need to live with code like this. My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant