-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ofbiz 11756 vue js renderer #57
Draft
Olivier-Heintz
wants to merge
24
commits into
apache:trunk
Choose a base branch
from
Olivier-Heintz:OFBIZ-11756_VueJs-renderer
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Ofbiz 11756 vue js renderer #57
Olivier-Heintz
wants to merge
24
commits into
apache:trunk
from
Olivier-Heintz:OFBIZ-11756_VueJs-renderer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin rename all flatgrey to fronjs or thfrontjs
Previous one has symbolic link not files
and correction for mini stylesheet which was with a old theme name
for add vuejs as children of html
div for Portal.vue
portal and portlet
(OFBIZ-11907) (#221) after modification in trunk: WidgetWorker now build URI and URL is build after call to WidgetWorker.
send directly target and targetType Currently, buildHyperlinkUri not supports uri with parameters write with {xxxx} should be study to know if it's a bug or parameters like this should not appear. in vuejs targetType is not yet manage, there will be some error/warning message added when code review will be done on this method
…reenBegin by renderBegin and same for close.
…id to load too many things
…se table has no th
there are some related comments on PR#27 |
Olivier-Heintz
force-pushed
the
OFBIZ-11756_VueJs-renderer
branch
from
March 3, 2021 15:04
57ef545
to
2ac85e5
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
SonarCloud Quality Gate failed. 2 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented: add plugins to have ofbiz components usable with the vuejs renderer (OFBIZ-11756)
Explanation
4 new addons: vuejs, themefrontjs, examplefjs and partyfjs to be able to have a complete usage of vuejs renderer (included in vuejs plugin)
This PR is to demonstrate frontjs renderer and vuejs implementation, to easily discuss on technical choices
Thanks: to Julien Bachelier for Vue.Js code in vuejs plugin