Math.random -> Random.nextDouble #32

- cancelAgreement - copyAgreement - getCommissionForProduct - createBudget - updateBudgetStatus - updateProductAverageCostOnReceiveInventory - getProductAverageCost (OFBIZ-8719)(OFBIZ-8720)(OFBIZ-8721)(OFBIZ-8749)(OFBIZ-8750)(OFBIZ-8751)(OFBIZ-8752) Thanks Deepak Nigam for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767773 13f79535-47bb-0310-9956-ffa450edef68

- copyPartyContactMechs - createCommunicationEvent - createCommunicationEventRole - createCommunicationEventRoleWithoutPermission - createCommunicationEventWithoutPermission - createContactMech - createEmailAddress - createPartyContactMech - createPartyContactMechPurpose - createPartyDataSource - createPartyEmailAddress - createPartyIdentifications (OFBIZ-8536)(OFBIZ-8509)(OFBIZ-8510)(OFBIZ-8511)(OFBIZ-8512)(OFBIZ-8513)(OFBIZ-8514)(OFBIZ-8515)(OFBIZ-8516)(OFBIZ-8517)(OFBIZ-8518)(OFBIZ-8519)(OFBIZ-8520) Thanks Akash Jain and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767776 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8536) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767777 13f79535-47bb-0310-9956-ffa450edef68

- createPartyNote - createPartyRelationship - createPartyRelationshipAndRole - createPartyRelationshipContactAccount - createPartyRelationshipType - createPartyTelecomNumber - createPersonAndUserLogin - createPostalAddress - createRoleType - createTelecomNumber - createUpdatePartyRelationshipAndRoles - deleteCommunicationEvent - deleteCommunicationEventWorkEffort Removed testCreatePartyContactMechPurpose test case as it was failing, will fix it in next commit. (OFBIZ-8521)(OFBIZ-8523)(OFBIZ-8524)(OFBIZ-8525)(OFBIZ-8526)(OFBIZ-8527)(OFBIZ-8528)(OFBIZ-8529)(OFBIZ-8531)(OFBIZ-8541)(OFBIZ-8542)(OFBIZ-8543)(OFBIZ-8544) Thanks Akash Jain and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767785 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8666) Adds a DELETE permission to deleteWorkEffortContent service implementation to be consistent with create and update. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767792 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8337) The above mentioned revision introduced a regression in which starting OFBiz in debug mode triggers classpath exceptions due to not finding certain jars. Upon investigation we realized that the new logic instantiates the loader class before the custom ClassLoader is instantiated. The fix would take a bit more time, hence reverting now to quickly resolve the issue and make the code base ready for the next release. The revert essentially re-introduce a List<StartupLoader> data set instead of a single StartupLoader. This is a minimal revert (less than 400 lines) instead of a full revert going above 2000 lines because we isolated only the parts that trigger the regression mentioned above. However, we should ideally revisit this code and clean it up again with careful attention to the class loading sequence. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767866 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8293) We already already discussed several times on dev ML about reducing the number of OOTB backend themes and we globally agreed about doing so. These themes are still working so we will move them to Attic from where (using svn history) they can be fetch to create expected plugins (tough I'm not sure we can yet create theme-plugins but this is expected) After the last discussion in dev ML this is a 1st step where I remove # bizzness time, still not complete after several years see OFBIZ-2398 # Dropping Crumbs, it's subsumed by Tomahawk which is the last variant of this group and more complete I'll then test all is OK (data are used so I need to clean my local DB) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767881 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8293) This completes the previous commit where bizzness time and Dropping Crumbs were removed git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767893 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8293) This completes the previous commits where bizzness time and Dropping Crumbs were removed git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767920 13f79535-47bb-0310-9956-ffa450edef68

- deletePartyContactMechPurpose - deletePartyContactMechPurposeIfExists - deletePartyRelationship - deletePartyRole - findPartiesById - findPartyFromEmailAddress - findPartyFromTelephone - findPartyFromTelephoneComplete - removeCommunicationEventRole - setCommEventComplete - setCommunicationEventRoleStatus - setCommEventRoleToRead - setCommunicationEventStatus - updateCommunicationEvent - updateCommunicationEventRole (OFBIZ-8545)(OFBIZ-8546)(OFBIZ-8548)(OFBIZ-8549)(OFBIZ-8550)(OFBIZ-8551)(OFBIZ-8552)(OFBIZ-8553)(OFBIZ-8554)(OFBIZ-8555)(OFBIZ-8556)(OFBIZ-8557)(OFBIZ-8558)(OFBIZ-8559)(OFBIZ-8560) Thanks Akash Jain and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767950 13f79535-47bb-0310-9956-ffa450edef68

…ntentType, PartyGeoPoint, PartyIcsAvsOverride, PartyIdentificationType, PartyQualType, PartyType, PartyTypeAttr, PaymentAttribute, PaymentBudgetAllocation, PaymentContentType, PaymentGroupType, PaymentMethodType, PaymentType, PaymentTypeAttr, PerfRatingType, PerfReviewItemType, PeriodType, PriorityType and ProdCatalogCategoryType entities. (OFBIZ-8606)(OFBIZ-8607)(OFBIZ-8608)(OFBIZ-8609)(OFBIZ-8610)(OFBIZ-8611)(OFBIZ-8612)(OFBIZ-8613)(OFBIZ-8614)(OFBIZ-8615)(OFBIZ-8616)(OFBIZ-8647)(OFBIZ-8648)(OFBIZ-8649)(OFBIZ-8650)(OFBIZ-8651)(OFBIZ-8724) (OFBIZ-8725)(OFBIZ-8726)(OFBIZ-8727) Thanks: Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767953 13f79535-47bb-0310-9956-ffa450edef68

- updateContactMech - updateEmailAddress - updatePartyEmailAddress - updatePartyGroup - updatePartyPostalAddress - updatePartyRelationship - updatePartyTelecomNumber - updatePerson - updatePostalAddress - updateTelecomNumber (OFBIZ-8561)(OFBIZ-8562)(OFBIZ-8563)(OFBIZ-8564)(OFBIZ-8565)(OFBIZ-8566)(OFBIZ-8567)(OFBIZ-8568)(OFBIZ-8569)(OFBIZ-8570) Thanks Akash Jain and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767955 13f79535-47bb-0310-9956-ffa450edef68

…AssocType, UserPrefGroupType, WebPreferenceType, WorkEffortAssocAttribute, WorkEffortAssocType, WorkEffortAssocTypeAttr, WorkEffortBilling, WorkEffortContentType, WorkEffortGoodStandardType, WorkEffortPurposeType, WorkEffortType, WorkEffortTypeAttr, WorkReqFulfType, UomType, UomGroup, ProductPricePurpose, ProductPriceType, ProductStoreGroupRole and ProductStoreGroupRollup entities. (OFBIZ-8729)(OFBIZ-8730)(OFBIZ-8792)(OFBIZ-8793)(OFBIZ-8794)(OFBIZ-8795)(OFBIZ-8796)(OFBIZ-8797)(OFBIZ-8798)(OFBIZ-8799)(OFBIZ-8800)(OFBIZ-8801)(OFBIZ-8802)(OFBIZ-8803)(OFBIZ-8788)(OFBIZ-8789)(OFBIZ-8767) (OFBIZ-8768)(OFBIZ-8769)(OFBIZ-8770) Thanks: Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767965 13f79535-47bb-0310-9956-ffa450edef68

- lookupParty - getPartyEmail - createAffiliate, updateAffiliate - getPartyMainRole - getPartyTelephone - quickCreateCustomer - createAddressMatchMap, removeAddressMatchMap, clearAddressMatchMap - createPartyInvitation, updatePartyInvitation, deletePartyInvitation - getPartyPostalAddress, - createPartyContactMechPurpose - createEmailAddressVerification - createPartyInvitationRoleAssoc, deletePartyInvitationRoleAssoc - updatePostalAddressAndPurposes - createPartyInvitationGroupAssoc, deletePartyInvitationGroupAssoc (OFBIZ-8669)(OFBIZ-8626)(OFBIZ-8627)(OFBIZ-8628)(OFBIZ-8629)(OFBIZ-8630)(OFBIZ-8631)(OFBIZ-8632)(OFBIZ-8633)(OFBIZ-8634)(OFBIZ-8635) (OFBIZ-8636)(OFBIZ-8637)(OFBIZ-8638)(OFBIZ-8639)(OFBIZ-8640)OFBIZ-8642)(OFBIZ-8643)(OFBIZ-8644)(OFBIZ-8645)(OFBIZ-8646) Thanks Akash Jain and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767968 13f79535-47bb-0310-9956-ffa450edef68

- createFinAccount - updateFinAccount - deleteFinAccount - createFinAccountStatus - createFinAccountTrans - createFinAccountRole - updateFinAccountRole - deleteFinAccountRole (OFBIZ-8814)(OFBIZ-8815)(OFBIZ-8816)(OFBIZ-8817)(OFBIZ-8818)(OFBIZ-8819)(OFBIZ-8820)(OFBIZ-8821) Thanks Deepak Nigam for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767972 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767974 13f79535-47bb-0310-9956-ffa450edef68

- createProduct, updateProduct - duplicateProduct - quickAddVariant - deleteProductKeywords - discontinueProductSales - createProductReview - updateProductReview - findProductById - createProductPrice, updateProductPrice, deleteProductPrice - createProductCategory (OFBIZ-8412)(OFBIZ-8506)(OFBIZ-8571)(OFBIZ-8654)(OFBIZ-8572)(OFBIZ-8573)(OFBIZ-8574) (OFBIZ-8656)(OFBIZ-8575)(OFBIZ-8576)(OFBIZ-8577)(OFBIZ-8578)(OFBIZ-8655) Thanks Akash Jain and Yash Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767977 13f79535-47bb-0310-9956-ffa450edef68

…ategoryContentType, ProductCategoryType, ProductCategoryTypeAttr, ProductContentType, ProductFeatureApplType, ProductFeatureIactnType, ProductMaintType, ProductMeterType, ProductOrderItem, ProductPriceActionType, ProductPriceAutoNotice, ProductStoreGroupType, ProductType, ProductTypeAttr and StatusType entities. Also converted services of ContactMechLink to entity-auto. (OFBIZ-8731)(OFBIZ-8732)(OFBIZ-8733)(OFBIZ-8734)(OFBIZ-8735)(OFBIZ-8736)(OFBIZ-8737)(OFBIZ-8762)(OFBIZ-8763)(OFBIZ-8764)(OFBIZ-8765)(OFBIZ-8766)(OFBIZ-8771)(OFBIZ-8772)(OFBIZ-8773)(OFBIZ-8774)(OFBIZ-8807) Thanks: Rahul Singh, Chinmay Patidar, Rohit Koushal and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768080 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7648) Thanks: Rohit Koushal and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768150 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8648) Thanks: Jacques for reviewing and reporting. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768151 13f79535-47bb-0310-9956-ffa450edef68

… and update service. (OFBIZ-8770) Thanks: Jacques for reviewing and reporting. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768152 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8461) Thanks: Jacques for reviewing and reporting. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768154 13f79535-47bb-0310-9956-ffa450edef68

…uto, applied slightly modify patch from jira issue. (OFBIZ-8895) Thanks Pawan Verma for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768157 13f79535-47bb-0310-9956-ffa450edef68

- getRateAmount - deleteRateAmount - updateRateAmount - getRatesAmountsFromWorkEffortId - getRatesAmountsFromPartyId - getRatesAmountsFromEmplPositionTypeId - updatePartyRate - deletePartyRate - filterRateAmountList (OFBIZ-8747)(OFBIZ-8753)(OFBIZ-8754)(OFBIZ-8755)(OFBIZ-8756)(OFBIZ-8757)(OFBIZ-8758)(OFBIZ-8759)(OFBIZ-8760)(OFBIZ-8761) Thanks Akash Jain and Pawan Verma for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768162 13f79535-47bb-0310-9956-ffa450edef68

…AgentType, UserAgentMethodType, FinAccountRole, BrowserType, PlatformType, ProtocolType, ServerHitType, UserAgent, FinAccount, FinAccountTypeGlAccount, VarianceReasonGlAccount, FixedAssetTypeGlAccount, InvoiceTerm, InvoiceContactMech, InvoiceContent entities. (OFBIZ-8785)(OFBIZ-8786)(OFBIZ-8790)(OFBIZ-8791)(OFBIZ-8805)(OFBIZ-8834)(OFBIZ-8835)(OFBIZ-8836)(OFBIZ-8837)(OFBIZ-8839)(OFBIZ-8881)(OFBIZ-8888)(OFBIZ-8892)(OFBIZ-8894)(OFBIZ-8916)(OFBIZ-8923)(OFBIZ-8928) Thanks: Rahul Singh, Rohit Koushal, Amit Gadalay and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768163 13f79535-47bb-0310-9956-ffa450edef68

…GatewayConfigType into entity-auto. (OFBIZ-8454)(OFBIZ-8455) Thanks: Jacques for reporting issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768166 13f79535-47bb-0310-9956-ffa450edef68

…he rule in one case and in next case it try to update the deleted data. Now it will fixed the test case failing issue. (OFBIZ-8814) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768167 13f79535-47bb-0310-9956-ffa450edef68

…ther instead of Exception in Java classes. (OFBIZ-8909)(OFBIZ-8910)(OFBIZ-8911)(OFBIZ-8912)(OFBIZ-8913)(OFBIZ-8914)(OFBIZ-8915)(OFBIZ-8917)(OFBIZ-8918)(OFBIZ-8919)(OFBIZ-8920)(OFBIZ-8921)(OFBIZ-8922) Thanks: Divesh Dutta for reporting and Amit Gaadaley for providing patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768168 13f79535-47bb-0310-9956-ffa450edef68

…with customers for any specific product from Catalog (OFBIZ-7713) Thanks: Swapnil Shah for suggesting this new featuer and Mohammad Kathawala for giving the patch git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768174 13f79535-47bb-0310-9956-ffa450edef68

…TransStatus service. (OFBIZ-8832)(8833) Thanks Deepak Nigam for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768175 13f79535-47bb-0310-9956-ffa450edef68

- cancelFixedAssetStdCost - createFixedAssetMaint - createFixedAssetMeter - createInvoice - copyInvoice - getInvoice - setInvoiceStatus - copyInvoiceToTemplate (OFBIZ-8840)(OFBIZ-8841)(OFBIZ-8844)(OFBIZ-8877)(OFBIZ-8878)(OFBIZ-8879)(OFBIZ-8880)(OFBIZ-8882) Thanks Deepak Nigam for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768181 13f79535-47bb-0310-9956-ffa450edef68

- createInvoiceItem - createInvoiceStatus - createInvoiceRole - createInvoiceTerm - cancelInvoice (OFBIZ-8896)(OFBIZ-8898)(OFBIZ-8900)(OFBIZ-89001) Thanks Deepak Nigam for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768183 13f79535-47bb-0310-9956-ffa450edef68

…enceValueItem, ProdCatalogInvFacility, StatusValidChange, SubscriptionActivity, SubscriptionAttribute, SubscriptionType, SubscriptionTypeAttr, SupplierRatingType, TaxAuthorityAssocType, TaxAuthorityRateType, TermType, TermTypeAttr, Uom, Addendum entities. (OFBIZ-8289) (OFBIZ-8307)(OFBIZ-8440)(OFBIZ-8728)(OFBIZ-8775)(OFBIZ-8776)(OFBIZ-8777)(OFBIZ-8778)(OFBIZ-8779)(OFBIZ-8780)(OFBIZ-8781)(OFBIZ-8782)(OFBIZ-8783)(OFBIZ-8784)(OFBIZ-8787)(OFBIZ-8964) Thanks: Rahul Singh, Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768184 13f79535-47bb-0310-9956-ffa450edef68

…es invoice when products have vat tax included in its price. Added new Invoice Item type for vat tax. This will enable posting taxes in liability account and actual product's price in revenue account. So this will eventually fix accounting transactions and reports. (OFBIZ-7012) Thanks: Thanks Ankush Upadhyay for your patch and Scott for design discussions git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768186 13f79535-47bb-0310-9956-ffa450edef68

- facility - marketting - return - entitysync Also moved the permission check from implementation level to service defination level (OFBIZ-8673)(OFBIZ-8673)(OFBIZ-8674)(OFBIZ-8739)(OFBIZ-8823)(OFBIZ-8825)(OFBIZ-8827)(OFBIZ-8850)(OFBIZ-8876)(OFBIZ-8875)(OFBIZ-8824)(OFBIZ-8826)(OFBIZ-8851) Thanks Nameet Jain for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768188 13f79535-47bb-0310-9956-ffa450edef68

…hen instantiating Collection implementation classes in Java files (OFBIZ-9023) (OFBIZ-9026)(OFBIZ-9027)(OFBIZ-9032)(OFBIZ-9034)(OFBIZ-9036)(OFBIZ-9030) Thanks: Divesh Dutta, Amit Gadaley and Shubham Agrawal for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768189 13f79535-47bb-0310-9956-ffa450edef68

…enamed facilityManagerPermission service to more generic name facilityPermissionCheck (OFBIZ-8013) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768190 13f79535-47bb-0310-9956-ffa450edef68

…ive checks. Utility method isEmpty or isNotEmpty is not needed to check if generic value is null or not because generic values can never be empty. They can be null or not nulls. So made changes accordingly all over the places. (OFBIZ-8471) Thanks: Ratnesh Upadhyay for reporting the improvement and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768192 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768193 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9046) Thanks: Rahul Singh and Amit Gadaley for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768195 13f79535-47bb-0310-9956-ffa450edef68

…payment status or void payment (OFBIZ-8738) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768196 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768199 13f79535-47bb-0310-9956-ffa450edef68

- CreateCustRequestItem - CreateCustRequestItemNote - CreateCustRequestNote - CreateCustRequestParty - CreateCustRequestStatus - CreateOrderDeliverySchedule - CreateOrderItemChange - CreateOrderPaymentApplication - CreateQuote - CreateQuoteAttribute - CreateQuoteCoefficient - CreateQuoteRole - CreateRequirement (OFBIZ-8947)(OFBIZ-8946)(OFBIZ-8948)(OFBIZ-8949)(OFBIZ-8950)(OFBIZ-8854)(OFBIZ-8855)(OFBIZ-8856)(OFBIZ-8951)(OFBIZ-8952)(OFBIZ-8963)(OFBIZ-8954)(OFBIZ-8955) Thanks Avnindra Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768206 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8445) (OFBIZ-8447) (OFBIZ-8448) (OFBIZ-8450) ( OFBIZ-8451) (OFBIZ-8653) (OFBIZ-8740) (OFBIZ-8741) (OFBIZ-8742) (OFBIZ-8743) Thanks: Devanshu Vyas, Anuj Jain, Sega Patidar, Abhijeet Ashapure for your patches git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768209 13f79535-47bb-0310-9956-ffa450edef68

…EW instead of READ. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768211 13f79535-47bb-0310-9956-ffa450edef68

- SetCustRequestStatus - GetRequirementsForSupplier - GetNextQuoteId - GetCustRequestsByRole - CreateRequirementRole - CreateRequirementFromItemATP - CreateCustRequestContent - CreateCustRequestAttribute - CreateAutoRequirementsForOrder - CreateATPRequirementsForOrder - CopyQuoteItem - CopyCustRequestItem (OFBIZ-8962)(OFBIZ-8961)(OFBIZ-8960)(OFBIZ-8959)(OFBIZ-8957)(OFBIZ-8956)(OFBIZ-8945)(OFBIZ-8944)(OFBIZ-8943)(OFBIZ-8942)(OFBIZ-8941)(OFBIZ-8940) Thanks Avnindra Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768214 13f79535-47bb-0310-9956-ffa450edef68

…e producing the inventory once production run gets completed. (OFBIZ-7108) Thanks: Swapnil Shah for suggesting this improvement and Anuj Jain for providing the patch git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768215 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768219 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768222 13f79535-47bb-0310-9956-ffa450edef68

…task also completed/cancelled) then don't allow new material to be added from Actual Material screen, Any completed taks for uncomplete Production Run should have WEGS created in COMPLETED status and WEIA created as well by issuing the added item's qty. (OFBIZ-7559) (OFBIZ-7468) Thanks: Swapnil Shah for suggestions and Anuj Jain for your patch git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768228 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8926) (OFBIZ-8927) Thanks: Ankush Upadhyay for the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768235 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9109) Thanks: Ankush Upadhyay for the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768237 13f79535-47bb-0310-9956-ffa450edef68

… if non-pks not passed than it should remain unupaded. (OFBIZ-8722) Thanks Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768239 13f79535-47bb-0310-9956-ffa450edef68

…ect pattern for Find Return Screen in Order component. (OFBIZ-7543) Thanks: Mohammad Kathawala for the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768240 13f79535-47bb-0310-9956-ffa450edef68

… to produced stock's unit cost for completed production run. Produced Item's inventory item i.e. = Total Actual Cost/ Produced in Stock. (OFBIZ-7111) Thanks: Swapnil Shah for suggesting the improvmeent and Anuj Jain for providing the patch git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768243 13f79535-47bb-0310-9956-ffa450edef68

…required parameters as option false as service in parameter. - createWorkEffortKeywords - createWorkEffortQuote - createWorkEffortRequest - createWorkEffortRequestItem - createWorkEffortRequestItemAndRequestItem - createWorkEffortReview - createWorkRequirementFulfillment (OFBIZ-8602)(OFBIZ-8603)(OFBIZ-8604)(OFBIZ-8605)(OFBIZ-8620)(OFBIZ-8621)(OFBIZ-8622) Thanks Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768252 13f79535-47bb-0310-9956-ffa450edef68

…evel. (OFBIZ-8358) Thanks Avnindra Sharma and Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768253 13f79535-47bb-0310-9956-ffa450edef68

…evel. (OFBIZ-8358) Thanks Avnindra Sharma and Pawan Verma for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768256 13f79535-47bb-0310-9956-ffa450edef68

…only required fields (OFBIZ-8723) Thanks Pawan Verma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768257 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8846) Thanks: Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768258 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8847) Thanks: Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768259 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-966) Thanks: Amit Gadaley and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768260 13f79535-47bb-0310-9956-ffa450edef68

- facility - workeffort - iCalendar - timesheet - quote (OFBIZ-7756)(OFBIZ-7818)(OFBIZ-7822)(OFBIZ-7832)(OFBIZ-7841) Thanks Avnindra Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768263 13f79535-47bb-0310-9956-ffa450edef68

- Agreement - Billing Account - Financial Account - Fixed Assets - Maintenance (OFBIZ-8180)(OFBIZ-8178)(OFBIZ-8177)(OFBIZ-8176)(OFBIZ-8175) Thanks Avnindra Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768265 13f79535-47bb-0310-9956-ffa450edef68

…dLine, PaymentGatewayConfig, PaymentGatewaySagePay, PaymentGatewayAuthorizeNet and PaymentGatewayClearCommerce entities. (OFBIZ-8970) (OFBIZ-8993)(OFBIZ-9081)(OFBIZ-9082)(OFBIZ-9087)(OFBIZ-9091) Thanks: Amit Gadaley, Rohit Koushal and Rishi Solanki for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768266 13f79535-47bb-0310-9956-ffa450edef68

- Feature Category - Product Store - DataResource - Template - CMS Content (OFBIZ-8187)(OFBIZ-8186)(OFBIZ-8185)(OFBIZ-8184)(OFBIZ-8183) Thanks Avnindra Sharma for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768267 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8744) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768274 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8926) (OFBIZ-8927) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768287 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8358) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768288 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768290 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768629 13f79535-47bb-0310-9956-ffa450edef68

… wherever it's possible, here with GenericEntityException and GenericServiceException. Also a generic case and tabs replaced git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768636 13f79535-47bb-0310-9956-ffa450edef68

…nt by renaming few updateShipmentGatewayConfig* service and request-maps to updateShipmentGateway* I stopped there, after things get more entangled and it's not worth continuing git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768649 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768655 13f79535-47bb-0310-9956-ffa450edef68

Thanks Suraj Khurana for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768662 13f79535-47bb-0310-9956-ffa450edef68

…ort' entity causing exception (OFBIZ-8822) Steps to regenerate: 1. Go to Entity Data Maintenance in webtools 2. Search entity 'AllExamplesWithDesiredCustomerFeaturesReport'. Click and go to the overview page. 3. Click on the Search button. Thanks: to Pritam Kute for report and Pallavi Goyal for patch git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768779 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768808 13f79535-47bb-0310-9956-ffa450edef68

…a new invoice Item git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768811 13f79535-47bb-0310-9956-ffa450edef68

Thanks Suraj Khurana for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769056 13f79535-47bb-0310-9956-ffa450edef68

…and 1762999. (OFBIZ-8722)(OFBIZ-8339)(OFBIZ-8723) As setting set-if-null to false fix one issue and introduced another one, reverting commit for now will debug it in more detail and will commit proper fix if found. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769057 13f79535-47bb-0310-9956-ffa450edef68

…build.gradle git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769294 13f79535-47bb-0310-9956-ffa450edef68

…nd while reading console log. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769586 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769598 13f79535-47bb-0310-9956-ffa450edef68

…tePartyContactMech form copyPartyContactMechs service. Also pass same parameter in testCreatePartyContactMech test case service. . git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769645 13f79535-47bb-0310-9956-ffa450edef68

…simple method, there is an bug in EntityAutoEngine. It causing test case failure. This is an quick fix. EntityAuto bug reported under ticket id OFBIZ-9117 git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769650 13f79535-47bb-0310-9956-ffa450edef68

…ntity auto, and fixed service definition for same, removed unused out parameter contactMechId from service definition, I don't understand purpose of this out parameter, and this service is used only in 3 places and not SECA rule define on it. So I think we can modify service definition. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1769755 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9119) Removes unused screens (commented out) in the CommonScreens widget in Catalog The SideCatalogs.* and SideDeepCategory.* files were already removed Thanks: Pierre Smits git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770037 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7725) Initially Swapnil Shah proposed to add a branchCode field in EftAccount and Check entities. Pierre mentioned that branchCode is actually the same than the existing rountingNumber field there. This adds a description for the rountingNumber field (also in PayrollPreference in humares) with a link to https://en.wikipedia.org/wiki/Bank_code where this field is explained for many countries. As suggested by Paul Foxworthy I added the Bank-State-Branch label for Australia. You might want to check the translation for you country or add it Finally I removed the FormFieldTitle_routingNumber in in humanres, it's not used anywhere and at least the French translation was wrong. Better to stick to AccountingRoutingNumber Thanks: Swapnil, Pierre and Paul for the helpful discussion git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770345 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7725) "As suggested by Paul Foxworthy I added the Bank-State-Branch label for Australia. You might want to check the translation for you country or add it" Oops forgot to commit the file in previsou commit :/ git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770391 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9121) I recently got a message from iso.org about several modifications in geos iso codes. This issue only concerns French changes which are important after some French regions have been unified. I'd appreciate a review by other French users, thanks :) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770423 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9120) In PartyUiLabels.xml the PartyCountryMissing label has been deleted but is still in use in one file Fix: Use the CommonCountryMissing label from CommonUiLabels instead Thanks: Heiko Elberg git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770441 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9121) Fixes a typo reported by Deepak on HipChat git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770474 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8617) Thanks Pierre Smits for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770481 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8340) Thanks Pierre Smits for your contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770483 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7323) Thanks Pierre Smits for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770490 13f79535-47bb-0310-9956-ffa450edef68

…eOnly dependency feature (OFBIZ-9118) The current build framework only supports compile and runtime dependencies but doesn't allow you to declare compile only dependencies which is important for non-transitive dependencies used only at compilation time. Thanks: Valery Chenzo git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770539 13f79535-47bb-0310-9956-ffa450edef68

… before trying to unbox (OFBIZ-8342) site-conf.xsd doesn't define transaction-timeout as being mandatory but ConfigXMLReader treats it as one and in the absence of the attribute an exception is being thrown causing the application to break. jleroux: I have slightly modified the patch, eventElement.getAttribute never returns null, default to empty Thanks: Valery Chenzo git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770540 13f79535-47bb-0310-9956-ffa450edef68

.getAttribute() never returns null, it defaults to empty Removes commented out import net.sf.json imports we use Jackson only (no license issues) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770543 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770621 13f79535-47bb-0310-9956-ffa450edef68

There are 2 webapps under pricat component: 1. visit /pricatdemo/ to play 3 demos; 2. visit /pricat/ to view pricat import history. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770622 13f79535-47bb-0310-9956-ffa450edef68

1. Add a readme. 2. Replace tabs with spaces. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1770979 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9126) I found that issue using ContactMechServices for updateContactMech: The default-message is dynamically set regarding to what contactMechType you are using. The problem was that the variable in property-field was never evaluated as that. Thanks: Mirko Vogelsmeier git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771440 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9124) Because of security reports CVE-2016-6816 and CVE-2016-8735 (both are important) this updates Tomcat to 8.0.39 git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771448 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9125) Issue: The errormessage "The password does not match the pattern" is called twice in LoginServices.java. Fix: Delete second assignment for variable "errMsg". jleroux: I simply removed the author commented out comment (2 lines) Thanks: Heiko Elberg git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771516 13f79535-47bb-0310-9956-ffa450edef68

This upgrade fixes the SuppressFBWarnings warnings occuring at compilation time. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771927 13f79535-47bb-0310-9956-ffa450edef68

…Xlint. I know it's in readme, but I tend to look directly in code... git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771932 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9124) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771935 13f79535-47bb-0310-9956-ffa450edef68

…IZ-7129) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771995 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772081 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8337) Continuing the refactoring work on the startup sequence, this commit specifically focuses on the ComponentContainer and how it loads components into the system. The following changes are made: - simplify and cleanup the ofbiz-containers.xml to have only one entry - substantially simplify the ComponentLoaderConfig class and remove unnecessary defined state - delete the JustLoadComponentsContainer (used to exist for the server command --testlist which no longer exists) - fully refactor the ComponentContainer class and breakup the messy logic into chunks of private methods. The methods are also properly documented. - remove an old reference to the testlist container which no longer exists git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772256 13f79535-47bb-0310-9956-ffa450edef68

…dyFromShipment service. This bug was introduced at r#1628288 while delegator to EntityQuery convertion. Also added complete code to check null shipment on setInvoicesToReadyFromShipment, code was incompletely implemented. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772346 13f79535-47bb-0310-9956-ffa450edef68

…fail (problem with Ecommerce frontend when using showPricesWithVatTax) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772354 13f79535-47bb-0310-9956-ffa450edef68

…ption Added PBKDF2 hash type to encrypt password. Thanks: wangjunyuan for this contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772589 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9123) 1. EXCELIMPORT_USERLOGIN is 3 chars too long. 2. should use titles in the relations. Thanks: Jacques points out these bugs. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772689 13f79535-47bb-0310-9956-ffa450edef68

Some runtime libraries were migrated fromt old jar files in OFBiz and are no longer necessary for the system to perform properly. Hence we are deleting these libraries from the build script dependencies. Discussion reference: http://markmail.org/message/j4ayk7zjzbaf7fhz git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772839 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8337) This is another major commit to the refactoring of the startup sequence in OFBiz with the following highlighted changes: - Delete the NativeLibClassLoader.java - Delete the native classpath logic in Classpath.java - Refactor the ComponentContainer and StartupControlPanel to operate without the NativeLibClassLoader. This substantially simplifies the code - Declare a URLClassLoader in ComponentContainer that is instantiated upon building the classpath for all components. This makes the classloader start in one shot - Simplify the Config file and remove fields that are not used. Also refactor some messy logic for loading the props file and other code improvements - Refactor all the .properties files for startup to have a consistent structure that clearly documents all available properties and the default value for each property. This change is also related to the changes applied on Config.java - Remove the declaration of the StartupLoader implementation class from all startup .properties files because only one implementation exists and it should be the default always. - Refactor the loaders retrieval code (main, rmi, test, load-data) defined in the startup .properties files - Refactor some switch statements to comply with java coding standards - Add the DTDs defined in base through Gradle because we removed the NativeLibClassLoader and the classpath buildup logic in StartupControlPanel Thanks: Jacopo Cappellato for reviewing the work git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772879 13f79535-47bb-0310-9956-ffa450edef68

… at r#1768222, this commit reversed key and description of drop-down in the code. (OFBIZ-9114) Thanks Wei Zhang for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8537) Change the currentPassword of flexadmin back to SHA format as the PBKDF2 password string in the patch doesn't follow RFC standard. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772899 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773029 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9123) Removed the following duplicated labels in PricatUiLabels.xml: ExcelTableNoRow ExcelTableColumnNumberNotMatch ExcelTableColumnNotMatch ExcelParsingRow Thanks: Jacques points out these bugs. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773058 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8537) Committed wangjunyuan's new patch. Thanks: wangjunyuan for the new patch to make the PBKDF2 hashed password comply with RFC 6070, the feedbacks of Jacques and Nicolas on the previous patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773066 13f79535-47bb-0310-9956-ffa450edef68

…3.07 as old git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773090 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8337) Fix a minor exclusion typo in the sourceSets block Thanks: Jacques Le Roux for reporting the issue git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773202 13f79535-47bb-0310-9956-ffa450edef68

…ce, if passed productId already exists than return uer friendly error message instead of entity exception. (OFBIZ-7402) Thanks Arvind and Padma for reporting the issue. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773213 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773337 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773338 13f79535-47bb-0310-9956-ffa450edef68

Thanks: Taher Alkhateeb for the report. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773354 13f79535-47bb-0310-9956-ffa450edef68

removed Cobertura some time ago. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773363 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773405 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773540 13f79535-47bb-0310-9956-ffa450edef68

… are even needed... git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773541 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773603 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9144) This is the first commit to the above mentioned issue which fixes many javadoc errors dispersed through the different components. The fixes are not necessarily improvements to the javadocs but rather making them valid javadocs to prevent reporting errors from gradle git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774154 13f79535-47bb-0310-9956-ffa450edef68

This is mostly related with the new pricat component and 2 files in cmssite (I guess also related with the new pricat component ) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774165 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9134) Thanks Paul Foxworthy and Suraj Khurana for your contribution git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774725 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774731 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774737 13f79535-47bb-0310-9956-ffa450edef68

…arty Detail screen. (OFBIZ-7683) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774772 13f79535-47bb-0310-9956-ffa450edef68

…mple Feature. (OFBIZ-7476) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774776 13f79535-47bb-0310-9956-ffa450edef68

…ment Roles. (OFBIZ-7511) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774785 13f79535-47bb-0310-9956-ffa450edef68

…ment Item Facility. (OFBIZ-7461) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774786 13f79535-47bb-0310-9956-ffa450edef68

…ment Item Party. (OFBIZ-7458) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774788 13f79535-47bb-0310-9956-ffa450edef68

…greement product. (OFBIZ-7441) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774790 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7430) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774794 13f79535-47bb-0310-9956-ffa450edef68

…Form. (OFBIZ-7436) Thanks: Ankit Joshi for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774796 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7429) Thanks: Padmavati Rawat for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774798 13f79535-47bb-0310-9956-ffa450edef68

…talog. (OFBIZ-7425) Thanks: Suraj Khurana for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774799 13f79535-47bb-0310-9956-ffa450edef68

…iation. (OFBIZ-7424) Thanks: Padmavati Rawat for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774800 13f79535-47bb-0310-9956-ffa450edef68

…m catalog manager. (OFBIZ-7307) Thanks: Suraj Khurana for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774801 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7984) Thanks: Deepak Nigam for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774802 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7952) Thanks: Deepak Nigam for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774804 13f79535-47bb-0310-9956-ffa450edef68

… form. (OFBIZ-7866) Thanks: Deepak Nigam for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774805 13f79535-47bb-0310-9956-ffa450edef68

… Authority Info). (OFBIZ-7437) Thanks: Padmavati Rawat for reporting and providing the patch. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774806 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9144) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774815 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774853 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9146) Refactoring form definitions with type='single' Refactoring various lists forms into grids. Refactoring various list form references in screen widgets into grid references Thanks: Pierre Smits git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774906 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9144) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774922 13f79535-47bb-0310-9956-ffa450edef68

This is part of the Javadoc refactoring issue as discussed in (OFBIZ-9144) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774933 13f79535-47bb-0310-9956-ffa450edef68

…rtoffset git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775238 13f79535-47bb-0310-9956-ffa450edef68

Improvements remove in total roughly 70 lines of code and includes: - moving all default values to the constructor to make it clear - refactor getProperty to use the Optional monad - remove FileInputStream from getPropertiesFile as it is not used - properly indent conditions in determineOfbizPropertiesFileName - simplify locale creation - remove dependency on base (StringUtil) - other minor renamings and formatting git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775340 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775441 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775597 13f79535-47bb-0310-9956-ffa450edef68

tokens from the LoginWorker class to a new class named ExternalLoginKeysManager. Improved Javadocs in the new class. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775807 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7766) Currently, InventoryItemTypeId attribute is empty for all Product entity's demo data. In real cases, there are products that are purely serialised (like equipments) or purely non-serialised (like liquid). Thanks: James Yong git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1775989 13f79535-47bb-0310-9956-ffa450edef68

ExternalLoginKeysManager.getExternalLoginKey(...) method. Minor refactoring of the getExternalLoginKey(...) method to make it more friendly to unit tests. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776138 13f79535-47bb-0310-9956-ffa450edef68

…ests. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776148 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9158) The idea is to use validate() to render a boolean result. I needed that in a custom project, I think it's worth contributing. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776243 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9158) Improves after a discussion with Scott and Taher on dev ML Improved to be called only with IN params, the JavaDoc is also improved to reflect the changes git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776447 13f79535-47bb-0310-9956-ffa450edef68

…E.md The old reference for gradle bash completion is broken. Hence using a newer fork that works correctly and in multiple environments git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776453 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9159) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776528 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9160) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776532 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9161) At OFBIZ-9159 I added the entity-auto CRUD services for JobSandbox but w/o permission check. While working on this issue I decided it's better to have them and decided to also put them for JobSandbox CRUD services. So here are the entity-auto CRUD services for RuntimeData and permission check for JobSandbox CRUD services git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776558 13f79535-47bb-0310-9956-ffa450edef68

…d.gradle (OFBIZ-9160) Gradle 3+ has deprecated the leftshift operator "<<" in favor of using the doLast closure. Hence all instances of the leftshift operator are replaced with doLast in build.gradle. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776642 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8316) Upgraded Apache Solr/Lucene from 5.3.1 to 6.2.1. Thanks: Michael Brohl and Cao PengAn for the contribution. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1776930 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9164) While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue due to r1652852 where Adrian improved the cacheKey in FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). Actually I'm not even sure it was done at r1652852 because Adrian did not maintain the FormFactory svn history. Anyway, to make a long story short I had to introduce a DispatchContext parameter when calling FormFactory.readFormDocument() when the code from R13.07 only passed a null. This had an impact in the hierarchy tree because FormFactory.readFormDocument() was called in DataResourceWorker class, where the new code was called from renderDataResourceAsText(). So I instead of only passing a Delegator I decided to pass only a LocalDispatcher parameter in renderDataResourceAsText(), since we can get the Delegator from the LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface and all related. I finally decided to apply the same "Change Method Signature" refactoring pattern (http://refactoring.com/catalog/addParameter.html) to all cases related to ContentWorkerInterface. No need to pass a delegator when you have LocalDispatcher! I locally got 5 incomprehensible test failures. After checking as much as I can w/o committing I believe it's a Windows 7 issue only. Anyway if Buildbot reports the same I'll revert. I need this changes in to continue on another not yet created subtask of OFBIZ-6919 git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777145 13f79535-47bb-0310-9956-ffa450edef68

Improved: Refactor ContentWorkerInterface methods signatures (OFBIZ-9164) While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue due to r1652852 where Adrian improved the cacheKey in FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). Actually I'm not even sure it was done at r1652852 because Adrian did not maintain the FormFactory svn history. Anyway, to make a long story short I had to introduce a DispatchContext parameter when calling FormFactory.readFormDocument() when the code from R13.07 only passed a null. This had an impact in the hierarchy tree because FormFactory.readFormDocument() was called in DataResourceWorker class, where the new code was called from renderDataResourceAsText(). So I instead of only passing a Delegator I decided to pass only a LocalDispatcher parameter in renderDataResourceAsText(), since we can get the Delegator from the LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface and all related. I finally decided to apply the same "Change Method Signature" refactoring pattern (http://refactoring.com/catalog/addParameter.html) to all cases related to ContentWorkerInterface. No need to pass a delegator when you have LocalDispatcher! I locally got 5 incomprehensible test failures. After checking as much as I can w/o committing I believe it's a Windows 7 issue only. Anyway if Buildbot reports the same I'll revert. I need this changes in to continue on another not yet created subtask of OFBIZ-6919 ........ Fixed: (OFBIZ-) Explanation Thanks: git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777154 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777159 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777273 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9164) While working on OFBIZ-6919 which was built on R13.07 I stumbled upon an issue due to r1652852 where Adrian improved the cacheKey in FormFactory.getFormFromLocation() by adding a delegator reference (Tenants). Actually I'm not even sure it was done at r1652852 because Adrian did not maintain the FormFactory svn history. Anyway, to make a long story short I had to introduce a DispatchContext parameter when calling FormFactory.readFormDocument() when the code from R13.07 only passed a null. This had an impact in the hierarchy tree because FormFactory.readFormDocument() was called in DataResourceWorker class, where the new code was called from renderDataResourceAsText(). So I instead of only passing a Delegator I decided to pass only a LocalDispatcher parameter in renderDataResourceAsText(), since we can get the Delegator from the LocalDispatcher. Doing so it had an impact on the renderDataResourceAsText hierarchy tree ending in DataResourceWorkerInterface and all related. I finally decided to apply the same "Change Method Signature" refactoring pattern (http://refactoring.com/catalog/addParameter.html) to all cases related to ContentWorkerInterface. No need to pass a delegator when you have LocalDispatcher! Since last commit and revert I fixed 5 test failures and improved the code more, mostly formatting, comments, etc. There are very ugly method signatures out there which still need refactoring, but it's so much work... git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777297 13f79535-47bb-0310-9956-ffa450edef68

I can't check here (Win7) because of: C:\projectsASF\ofbiz\framework\common\src\main\java\org\apache\ofbiz\common\ UrlServletHelper.java:251: error: unmappable character for encoding Cp1252 str = str.replace("´╝?", "-"); git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777310 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777311 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777446 13f79535-47bb-0310-9956-ffa450edef68

… not yet ready to be committed. Only remains a not functional change, only formatting and imports cleaning of FormRenderer.java Sorry for the trouble git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777448 13f79535-47bb-0310-9956-ffa450edef68

…zation in ContentWorker for Birt Report Builder (OFBIZ-9166) This is still an incomplete feature because I did not find yet a way to complete the BIRT_REPORT_BUILDER_USAGE_POLICY and had to bypass the sanitization for this case, WIP... This commit has no effect on OFBiz yet. I need to commit this now to continue to work on the main task: OFBIZ-6919 "New implementation of Birt. Easier user possibility of report creation". git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777451 13f79535-47bb-0310-9956-ffa450edef68

report creation (OFBIZ-6919) This are a non functional changes not yet used OOTB. They are only intended to ease the sync between the svn trunk repo and the github branch (using a fork) So still a WIP... git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777586 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9169) In OFBIZ-5409 a prefix was added for GET ajax requests. It would be beneficial if the prefix could be configured instead of hard coded Pierre Smits suggested to make the feature multi-tenant aware. I made signature and calls changes based on Chris Howe's patch. Thanks: Chris Howe and Pierre Smits git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1777942 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7972) In another step towards completing the plugin system for OFBiz, we renamed the /specialpurpose directory to /plugins and changed all occurences of the word "specialpurpose" to "plugins" in all files found in the system Reference discussion: http://markmail.org/message/hpyuxkmftiyn44w2 git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778271 13f79535-47bb-0310-9956-ffa450edef68

Adds a note for JDBC drivers Move the Security section below the Quick start section git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778413 13f79535-47bb-0310-9956-ffa450edef68

Adds a note for % progress indicator git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778415 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778420 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9164) Fixes an issue in the ShowCartItems.ftl file reported by Deepak Actually I was overzealous with this. Reverting a simple change were I changed a parameter in the signature of the protected ShoppingCartItem() method from ShoppingCart.ShoppingCartItemGroup to ShoppingCartItemGroup should be enough Thanks: Deepak for report git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778421 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778431 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778433 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-7795) In rc scripts, the calls to gradlew should be prefixed with ./ git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778576 13f79535-47bb-0310-9956-ffa450edef68

I think I'll make it a README.MD and use the same pandoc mechanism than for Gradle migration page, to create a dynamic page in wiki based on this file. I'll also update the releasing page in wiki to add all files which need an update when releasing. So far, if it misses, the doap_OFBiz.rdf in website and this one git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778759 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9172) Currently no support for New Zealand regions in framework/common/data/GeoData_* Thanks: David McNeill git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778879 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778880 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9173) Depreciation is mis-spelled as depreciatiion Also, an additional space before brace would improve readability Assigned is mis-spelled as assinged Grammar of sentence could be updated for readability. Thanks: David McNeill git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778881 13f79535-47bb-0310-9956-ffa450edef68

tools/demo-backup/README file to tools/demo-backup/README.MD With some edition git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778882 13f79535-47bb-0310-9956-ffa450edef68

…e and related helpful pandoc.bat The README.md.html is to be used at https://cwiki.apache.org/confluence/display/OFBIZ/ The+official+demos+and+how+to+maintain+them git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778883 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778888 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9167) -go to https://localhost:8443/ordermgr/control/orderentry -create order for DemoCustomer -add an item console output... java.lang.NullPointerException at org.apache.ofbiz.content.content.ContentWorker. renderContentAsText(ContentWorker.java:368) ~[ofbiz.jar:?] [...] While at it I also found issues with cartLine.getName() in ftl files. It was also missing the dispatcher. This was broken by OFBIZ-9164 Thanks: Wai git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1778889 13f79535-47bb-0310-9956-ffa450edef68

There was a need of huge horizontal scroll in the Security block. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779311 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9183) We decided to remove the cleanGradle because since we upgraded to Gradle 3 it causes an issue on Windows. We also decided to remove the cleanAnt Gradles Task because it's now in the R16.11.01 and R11.1 branch which should be enough for users moving from Ant to Gradle BTW in case of need there is this wiki reference page https://cwiki.apache.org/confluence/display/OFBIZ/From+Ant+to+Gradle git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779439 13f79535-47bb-0310-9956-ffa450edef68

…r run (OFBIZ-9155) Symptom: * services that are invoked with "dispatcher.runAsync" stay "pending" in the job-list and never get executed * scheduled jobs don't get executed Steps to Reproduce * Login to /webtools * Schedule a Job to run in 5 mins, (for example service "clearAllEntityCaches") * Wait 7mins Expected: * the scheduled service "clearAllEntityCaches" is not "pending" anymore but should have status "finished" Actual: * scheduled service "clearAllEntityCaches" is still "pending" Analysis: The problem can be reproduced with the OFBiz 16.11 branxh as well as with the OFBiz 16.11.01 zip file version and the trunk JobPoller does get started on OFBiz start but does get stuck on line: org.apache.ofbiz.service.job.JobPoller.java: 213-215 The reason is that the "Start.ServerState" never reaches "RUNNING" Doing a full-text scan through the whole source code shows, that there is no code at all that sets the ServerState to "RUNNING" Comparing it to the 15.11-branch. There used to be a line: serverState.compareAndSet(ServerState.STARTING, ServerState.RUNNING) no such line exists in 16.11 anymore. jleroux: I confirm the behaviour in R16 branch as well as in trunk. Leonard's "patch" is a good solution and works for the R16 branch which is less changed than the trunk when compared to R15. The same applies to the trunk with the relative block of code which contains if (serverState.get() == ServerState.STOPPING) { The line Leonard propose to add was obviously missed during the recent refactoring. Thanks: Leonard Lin git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779596 13f79535-47bb-0310-9956-ffa450edef68

…uired (OFBIZ-9184) Currently in the entitymodel.xsd the line <xs:attribute name="entity-alias" type="xs:string"/> is wrong, should be <xs:attribute name="entity-alias" type="xs:string" use="required"/> Else in line this.entityAlias = entityAlias; in ModelViewEntity.ViewConditionExpr() this.entityAlias receives null. All supported branches are concerned git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779625 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779677 13f79535-47bb-0310-9956-ffa450edef68

Easier user possibility of report creation. (OFBIZ-6919) Fixes a small issue: the REPORT contentId is now named FLEXIBLE_REPORT Note: the BIRT_REPORT_BUILDER_USAGE_POLICY still need to be completed. Hence it's for now bypassed in ContentWorker.renderContentAsText(), based on the FLEXIBLE_REPORT contentId git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779701 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9157) Steps to Reproduce: - Create a sales order - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product - set the status of the order to completed - go to order-management and try to open the order for display like: https://localhost:8443/ordermgr/control/orderview?orderId=XXXXX Expected: - the order is displayed with status completed Actual: - A groovy exception is displayed. Analysis: The service "getReturnableQuantity" throws an exception because it returns the returnablePrice = null, because the unitPrice of the orderItem was null. The OUT field returnablePrice is mandatory according to the service-definition. The return parameter is set but the value is null, hence the exception. Solution: adjust the service-definition to allow for "null" value of the returnablePrice OUT parameter. Thanks: Leonard Lin git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779724 13f79535-47bb-0310-9956-ffa450edef68

…n empty action here git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1779934 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-8316) Change LongPoint and DoublePoint fields to String field to make solr work in trunk version, and I'll change them back when updating to new release of Solr. Thanks: Jacques Le Roux for reporting the point fields problem. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780133 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780493 13f79535-47bb-0310-9956-ffa450edef68

…ugh. Despite missing the creation data in svn, I guess this file has been created after I created the portoffset feature or I missed it then (unlikely since I changed all 8080 and 8443 ports in Java code). Anyway, we now need this to be portoffset aware and this commit just does that git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780659 13f79535-47bb-0310-9956-ffa450edef68

…t. Easier user possibility of report creation. (OFBIZ-6919) The concept, you define a report domain related to an entity or a service through a master content (master report) and a master search form. When a high level user create a report on a configured domain, OFBiz prepare an instantiation of the master content (flexible report) that permit to surcharge the search form (recorded dynamically on the content as ElectronicText) and prepare a rptDesign skeleton. The high level user can download the rptDesign to edit it trhough the birt editor, with all fields that ofbiz will be load as dataset and when is finish upload the result on the content instantiation. For the end user, he selected the instantiation report, OFBiz display the report search from the content instantiation and the submission call birt with the search parameters and the linked rptDesign. The rptDesign file is drive by OFBiz to build the data set by two methods : * call the performFind if the domain is related to an entity * call the a custom service if the domain is related to a service. For the last case we need two services, a first who prepare and list available fields for search and display. And a second who realize the search. By convention currently the first service as the same name that the second service suffixed by 'PrepareFields' This commit contains : * useful UI to create a new content instance from a master content. List, edit, remove a content instance and a simple drop-down to list all instance published (ready to use by end user) * all services (with the work flexibleReport) to manage a flexible report, prepare the rptDesign skeleton, reanalyze the rptDesign uploaded, prepare the search form * Services interface to define you own search custom method * Two examples, one on the entity Exemple and one with the service flexibleReportTurnOver. Warning ! there are raw example without a beautiful rptDesign so you need to update the rptDesign with the birt editor to display something. Thanks: François Wurmser for initialize this improvement, Jacques and Gil for their time to analyze, document and refactor the code git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780683 13f79535-47bb-0310-9956-ffa450edef68

Because the log level always is display as FATAL on log, this raise useless log and generate many noise for production site. Generally these logs are present for debugging historical reason git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780691 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9182) This commit provides the following: - Fully refactor common.gradle so that it mirrors the component loading logic found in ComponentContainer. This makes the loading very flexible and changing the directory structure should have no impact on the build scripts. - Gradle will now ignore a component if it exists but disabled in ofbiz-component.xml (i.e. enabled="false") - Removes /plugins/component-load.xml - Disables the ebaystore component in ofbiz-component.xml The above is needed as a first step toward preparing the project for svn restructure git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780790 13f79535-47bb-0310-9956-ffa450edef68

The code came from a project under ofbiz 13.07 and is still using deprecated delegator.find calls, so I converted them to EntityQuery git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780800 13f79535-47bb-0310-9956-ffa450edef68

…ention git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780801 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9182) In preparation for moving to a new svn, we removed the component-load.xml file which was the way in which components were activated / deactivated in /plugins. This is made redundant and hence removing unnecessary code. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780828 13f79535-47bb-0310-9956-ffa450edef68

… commit (OFBIZ-9182) git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1780832 13f79535-47bb-0310-9956-ffa450edef68

…roller to be the same than in birt controller git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781037 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9192) The Birt Report Builder can also use services. for now only the "rotation" report as been provided. We can provide more examples based on François' work. Here are trivial changes fixes missing Lookup maps and view in controller for the "rotation" report new needed labels typos fixed Thanks: git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781084 13f79535-47bb-0310-9956-ffa450edef68

…ctions for fixed asset depreciations. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781109 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9191) This is due to a change in (at least) Tomcat 8.0.39 Here is a simple fix. I tried other ways but none worked and I prefer to keep this simple. I tried other ways but none worked and I prefer to keep this simple. * Using an encoder at this stage (just before calling the macro) is not an option. Or maybe by using the encoder on the linkurl variable alone. But then linkurl must be transformed in a String and back to a StringBuilder or more refactoring is needed. It does not worth it IMO. * Also using encode="true" for links in AccountingTrees.xml does not work. This also removes trailing blanks (by hand) Thanks: Moatasim Al Masri for report git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781125 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781202 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781209 13f79535-47bb-0310-9956-ffa450edef68

Adds a missing BirtOverrideFilters label Fixes a typo in BirtServices.java and organise imports Change a button name in BirtForms.xml Uses the BirtOverrideFilters label in BirtScreens.xml git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781215 13f79535-47bb-0310-9956-ffa450edef68

…it you need to do other actions (OFBIZ-9194) You need to add the data set fields with the Birt Report Designer and publish the report. This will be documented with OFBIZ-9188 I thought about graying the button but it was a delicate matter because it uses a <content element in screen and directly call a view handled from a Groovy event. It was easier to fix the PrepareBirtCall Groovy event. But to be totally sure I also handled the possible NPE in the BirtViewHandler I also fixed viewLast error in controller Because the files were not committed with the svn:eol-style native property you will see false changes in this commit. Some files have their svn:eol-style native property set. I'll soon commit missing so in new Birt Java files. I'll also commit a lot of svn:eol-style native property changes for XML and Groovy files which have been neglected so far. I'm sorry for that because when we do so we loose the annotations history. I will then definitely put in place what I suggested in http://markmail.org/message/ffmyw773p65fndey git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781218 13f79535-47bb-0310-9956-ffa450edef68

At http://markmail.org/message/ffmyw773p65fndey I wrote: I'd like to follow the suggestion I made in the last message of the linked thread. In other words, use http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-config http://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops Then this problem would be over. No longer need to check from time to time that concerned files, have svn:eol-style=native property set This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà Then at markmail.org/message/h3q2yvj4db544ro7 I wrote: Actually, since we get new committers now and then and their are able to create new files I have a warning every 6 months which says "Check Java files, have all svn:eol-style=native" (I totally forgot that because I assume the machine knows it and warns me ;)) I could extend that to all files (at least the most prominent types), I'll see... This does what the last sentence said for Groovy, XML and few new Birt Java files. I'll see if I can implement the svn 1.8 repos-dictated-config ASAP! git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781219 13f79535-47bb-0310-9956-ffa450edef68

Improved: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781366 13f79535-47bb-0310-9956-ffa450edef68

I did not even notice I committed this bunch of WIP stuff. I guess I clicked somewhere while my machine was too buzy git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781367 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781431 13f79535-47bb-0310-9956-ffa450edef68

…po root git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781441 13f79535-47bb-0310-9956-ffa450edef68

…vel, it's now set at OFBiz svn repo root level git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781446 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9198) When accessing a file/image in ecomseo (only seo version) that is physically missing or the dataresource attribute isPublic=="N" the request results in a loop. jleroux: to break the loop in case or error, I simply decided to return a response of type none. I also added the same for io-error which can be returned by the DataEvents class, also in ecommerce controller Thanks: Ingo Wolfmayr for report git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781662 13f79535-47bb-0310-9956-ffa450edef68

completes r1781219 by putting svn:eol-style=native to all file types declared in [auto-props] section of the svn config files.css Actually this is only a 1st pass, it was too complicated to do it for all file types at once only concerned here *.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml; *.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd *.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw Most files should not be concerned by this change, but it's impossible to do it one by one. There are also changes in files with have mixed EOLs; because this has no sense when using native which automatically resolves this issue git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781731 13f79535-47bb-0310-9956-ffa450edef68

Completes r1781731 by putting svn:eol-style=native to *.sh;*.bat file types There are also changes in files with have mixed EOLs because this is no sense when using native which automatically resolves this issue git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781735 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9204) Thanks: Maurice for reporting and providing the patch, Deepak and Jacques for their suggestions. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781979 13f79535-47bb-0310-9956-ffa450edef68

Currently the class BirtContainer call the birt engine with hard coded log level ALL that generated huge log file. We can't implement easily log4j on the birt engine so with this commit I create a quick fix to have matching between the java.util.Logger and org.apache.log4j.Logger level. You can select the log level from debug.properties to populate the ReportEngine log file. git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782070 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9152) Since the introduction of EntityQuery there was no distinction between a simple method tags <find-by-and use-iterator="true"> and <find-by-and use-iterator="false"> (except cache handling). There is a condition "if (useIterator)" but with entityQueries did use "[...].queryList()". Thanks: Mirko Vogelsmeier git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782498 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9208) Adrian created the following commit to cache URL objects Revision: 1649979 Author: adrianc Date: 07 January 2015 00:24:28 Message: Some optimizations for URL lookups. ---- Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java and was later reverted in this commit Revision: 1650347 Author: adrianc Date: 08 January 2015 17:53:59 Message: Some small fixups for some of my previous commits. ---- Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java We have found in one of our production servers that line 98 in UtilURL.java url = loader.getResource(resourceName); has caused locking and looking at the stack trace (from jstack). There are numerous threads waiting on locks from within this method I propose the cache gets added back (we have done this as a patch on our systems with no ill effect) FYI - The commits are in reference to the EntityClassLoader which is not used and does not work see OFBIZ-6210 Thanks: Gareth Carter for report and suggestion git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782520 13f79535-47bb-0310-9956-ffa450edef68

(OFBIZ-9186) Refactoring various list forms into grids Refactoring various list form references in screens Thanks: Pierre Smits git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782562 13f79535-47bb-0310-9956-ffa450edef68

Fixed: (OFBIZ-9211) "gradlew cleanAll loadDefault" generates a data loading error It's logically due to the removing of plugins/component-load.xml in OFBIZ-9182 A temporary solution is to put it in again. A definitive solution is to remove data dependencies. We have also this problem with ecommerce data which create dependencies from applications jleroux: I don't close this issue yet because we need to work together on this. I simply remove the regression by putting back plugins/component-load.xml Thanks: Wai for report git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782577 13f79535-47bb-0310-9956-ffa450edef68

Only higher will be considered, not done yet... git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782603 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782604 13f79535-47bb-0310-9956-ffa450edef68

…le plugin (OFBIZ-9182) Added a new gradle task called pullPluginSource that fetches a plugin from the (yet to be created) plugins repository. Also updated the README.md file to reflect the changes that happened recently on the plugin management tasks This is the last commit required before restructuring the subversion repository as per the discussion thread mentioned in the above JIRA git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782605 13f79535-47bb-0310-9956-ffa450edef68

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782651 13f79535-47bb-0310-9956-ffa450edef68

…ts" (Pushed into wrong branch) This reverts commit fca276a.

Math.random -> Random.nextDouble #32

Are you sure you want to change the base?

Math.random -> Random.nextDouble #32

Commits on Nov 2, 2016

Commits on Nov 3, 2016

Commits on Nov 4, 2016

Commits on Nov 5, 2016

Commits on Nov 6, 2016

Commits on Nov 8, 2016

Commits on Nov 9, 2016

Commits on Nov 10, 2016

Commits on Nov 11, 2016

Commits on Nov 14, 2016

Commits on Nov 15, 2016

Commits on Nov 16, 2016

Commits on Nov 18, 2016

Commits on Nov 19, 2016

Commits on Nov 20, 2016

Commits on Nov 21, 2016

Commits on Nov 23, 2016

Commits on Nov 26, 2016

Commits on Nov 29, 2016

Commits on Nov 30, 2016

Commits on Dec 1, 2016

Commits on Dec 2, 2016

Commits on Dec 5, 2016

Commits on Dec 6, 2016

Commits on Dec 7, 2016

Commits on Dec 8, 2016

Commits on Dec 9, 2016

Commits on Dec 10, 2016

Commits on Dec 11, 2016

Commits on Dec 14, 2016

Commits on Dec 17, 2016

Commits on Dec 18, 2016

Commits on Dec 20, 2016

Commits on Dec 21, 2016

Commits on Dec 22, 2016

Commits on Dec 23, 2016

Commits on Dec 24, 2016

Commits on Dec 27, 2016

Commits on Dec 28, 2016

Commits on Dec 29, 2016

Commits on Dec 30, 2016

Commits on Jan 2, 2017

Commits on Jan 3, 2017

Commits on Jan 4, 2017

Commits on Jan 5, 2017

Commits on Jan 6, 2017

Commits on Jan 9, 2017

Commits on Jan 11, 2017

Commits on Jan 12, 2017

Commits on Jan 13, 2017

Commits on Jan 14, 2017

Commits on Jan 15, 2017

Commits on Jan 18, 2017

Commits on Jan 19, 2017

Commits on Jan 20, 2017

Commits on Jan 21, 2017

Commits on Jan 23, 2017

Commits on Jan 25, 2017

Commits on Jan 27, 2017

Commits on Jan 28, 2017

Commits on Jan 29, 2017

Commits on Jan 31, 2017

Commits on Feb 1, 2017

Commits on Feb 2, 2017

Commits on Feb 4, 2017

Commits on Feb 5, 2017

Commits on Feb 7, 2017

Commits on Feb 10, 2017

Commits on Feb 11, 2017

Commits on Feb 12, 2017

Commits on May 10, 2019

Commits on May 11, 2019