Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPI configurations for the standalone mode #5476

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

style95
Copy link
Member

@style95 style95 commented Apr 13, 2024

Description

We need to explicitly configure SPIs for the standalone mode as we updated our default SPI configurations.

Related issue and scope

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@style95 style95 requested a review from dgrove-oss April 13, 2024 01:01
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgrove-oss
Copy link
Member

Would this be enough to allow us to remove https://github.com/apache/openwhisk/blob/master/.github/workflows/4-standalone.yaml#L68-L69 or does that script do more?

@style95
Copy link
Member Author

style95 commented Apr 15, 2024

@dgrove-oss
Thanks for the comment, let me try that.

@@ -65,8 +65,6 @@ jobs:
sudo rm -rf "$AGENT_TOOLSDIRECTORY"
- name: Check free space
run: df -h
- name: Disable the scheduler
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now obvious that we don't need this step.

@style95 style95 merged commit 7863e27 into apache:master Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants