Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-11704. Hadoop test leaves running containers in case of failure #7435

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

adoroszlai
Copy link
Contributor

@adoroszlai adoroszlai commented Nov 14, 2024

What changes were proposed in this pull request?

Hadoop's containers are left running if Hadoop test fails.

Steps to reproduce (by simulating failure):

cd hadoop-ozone/dist/target/ozone-2.0.0-SNAPSHOT/compose
sed -i -e 's/execute_command_in_container rm hadoop version/exit 1/' common/hadoop-test.sh
cd ozone
./test-hadoop.sh
docker ps

Result:

CONTAINER ID   IMAGE                  COMMAND                  CREATED         STATUS         PORTS                                                                      NAMES
983d0cd0fe79   apache/hadoop:2.10.2   "/usr/local/bin/dumb…"   8 seconds ago   Up 7 seconds   0.0.0.0:8088->8088/tcp, :::8088->8088/tcp                                  ozone-rm-1
89b8ddc1c331   apache/hadoop:2.10.2   "/usr/local/bin/dumb…"   8 seconds ago   Up 7 seconds                                                                              ozone-nm-1

https://issues.apache.org/jira/browse/HDDS-11704

How was this patch tested?

Same steps as described in repro. Verified that no containers are left running.

CI:
https://github.com/adoroszlai/ozone/actions/runs/11843661370

@adoroszlai adoroszlai self-assigned this Nov 14, 2024
Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @adoroszlai, looks good to me.

@adoroszlai adoroszlai merged commit cc1a374 into apache:master Nov 25, 2024
28 checks passed
@adoroszlai adoroszlai deleted the HDDS-11704 branch November 25, 2024 10:12
@adoroszlai
Copy link
Contributor Author

Thanks @dombizita for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants