-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid call finalizeStage more times than once. (#1650) #1654
base: 1.1.x
Are you sure you want to change the base?
Conversation
(cherry picked from commit 7fef5b7)
It will cause problems in 1.0.x, but still, it may call twice |
Can we hold off merging to patch branches for a few days so that the changes can be more widely reviewed? |
@pjfanning Okay, Let's do this next weekend. |
My preference is not to backfit changes that are not definitely causing major issues. |
let's keep this open to see if a user requests it. |
(cherry picked from commit 7fef5b7)