Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid call finalizeStage more times than once. (#1650) #1654

Draft
wants to merge 1 commit into
base: 1.1.x
Choose a base branch
from

Conversation

He-Pin
Copy link
Member

@He-Pin He-Pin commented Dec 31, 2024

(cherry picked from commit 7fef5b7)

@He-Pin He-Pin requested a review from pjfanning December 31, 2024 12:21
@He-Pin He-Pin added the t:stream Pekko Streams label Dec 31, 2024
@He-Pin He-Pin added this to the 1.1.3 milestone Dec 31, 2024
@He-Pin He-Pin added the bug Something isn't working label Dec 31, 2024
@He-Pin He-Pin linked an issue Dec 31, 2024 that may be closed by this pull request
@pjfanning
Copy link
Contributor

You keep raising PRs against the wrong branch.

image

I don't think this should be merged to 1.1 yet. I am not convinced that this issue is causing major issues and therefore would not justify being added in a patch.

@He-Pin He-Pin changed the base branch from main to 1.1.x December 31, 2024 12:36
@He-Pin
Copy link
Member Author

He-Pin commented Dec 31, 2024

It will cause problems in 1.0.x, but still, it may call twice GraphStageLogic#postStop in 1.1.x, and we are using it at work :(

@pjfanning
Copy link
Contributor

Can we hold off merging to patch branches for a few days so that the changes can be more widely reviewed?

@He-Pin
Copy link
Member Author

He-Pin commented Dec 31, 2024

@pjfanning Okay, Let's do this next weekend.

@pjfanning
Copy link
Contributor

My preference is not to backfit changes that are not definitely causing major issues.
With the main branch, we could start doing milestone releases, eg 1.2.0-M1. We just need more people to get involved in voting on releases.

@He-Pin
Copy link
Member Author

He-Pin commented Jan 2, 2025

let's keep this open to see if a user requests it.

@He-Pin He-Pin modified the milestones: 1.1.3, 1.1.x Jan 2, 2025
@He-Pin He-Pin marked this pull request as draft January 2, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working t:stream Pekko Streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed : java.lang.NullPointerException: IN ActorGraphInterpreterSpec
2 participants