Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: doCommitOffsets of PulsarKafkaConsumer in version 2.11.0 #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

avinash-fk
Copy link

@avinash-fk avinash-fk commented May 4, 2023

Fixes #48

Master Issue: #48

Motivation

doCommitOffsets method in Pulsar Kafka Client version 2.11.0 is not working for partitioned topics. This does not allows acking messages.

Modifications

In doCommitOffsets PulsarKafkaConsumer.java creating TopicMessageIdImpl with the correct partition name

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, provided we create it as a partitioned topic

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

Can you please add a unit test?

@dlg99 PTAL

Copy link
Contributor

@dlg99 dlg99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs a test that reproes original problem

@avinash-fk
Copy link
Author

@eolivelli @dlg99 added a unit test for commitSync, specifically on how acknowledgeCumulativeAsync is called inside doCommitOffsets. Let me know if there is any thing else required.

@avinash-fk
Copy link
Author

@dlg99, any idea when can this be merged if everything is good? Also, can a patch version be released with this fix ?

@avinash-fk avinash-fk requested review from dlg99 and eolivelli May 16, 2023 12:04
pom.xml Show resolved Hide resolved
@tisonkun
Copy link
Member

I support to merge this patch. @dlg99 @eolivelli could you give another look?

@tisonkun tisonkun changed the title [Issue#48]: Fixed bug in doCommitOffsets of PulsarKafkaConsumer in version 2.11.0 fix: doCommitOffsets of PulsarKafkaConsumer in version 2.11.0 Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in doCommitOffsets of PulsarKafkaConsumer [Ver: 2.11.0]
4 participants