Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initContainers to templates #516

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

CodePrometheus
Copy link
Contributor

Motivation

Fixes #491,#240

Modifications

  • Add initContainers to the templates of each component.
  • Add examples/values-init-containers.yaml.

Verifying this change

  • Make sure that the change passes the CI checks.

@CodePrometheus
Copy link
Contributor Author

The CI error does not seem to be related to this change.

+ /home/runner/work/pulsar-helm-chart/pulsar-helm-chart/output/bin/kubectl exec -n pulsar pulsar-ci-toolset-0 -- bin/pulsar-admin tenants create pulsar-ci
null

Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. Failed reason: pulsar-ci-broker

@lhotari Teacher Lari, could you help with code review, thanks.

@lhotari
Copy link
Member

lhotari commented Aug 5, 2024

thanks for the contribution @CodePrometheus! Great work

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari merged commit 093fa27 into apache:master Aug 5, 2024
31 checks passed
@CodePrometheus CodePrometheus deleted the feat-initContainers branch August 6, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins support
2 participants