SAMZA-2802: fetch empty topic metadata #1710
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the situation when a topic is empty, but not new (begin offset == end offset != 0) in fetchTopicPartitionsMetadata we subtract 1 from the end offset:
newestOffsets.put(KafkaUtil.toSystemStreamPartition(this.systemName, topicPartition), String.valueOf(offset - 1L));
and later in validateRestoreOffsets:
we get endingOffset < startingOffset because of subtraction of 1 in fetchTopicPartitionsMetadata.
In this PR if-else block was added to don't subtract 1 from the ending offset when its equal to the beginning offset.