Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor error-handler module #2345

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Refactor error-handler module #2345

merged 7 commits into from
Oct 31, 2023

Conversation

terrymanu
Copy link
Member

No description provided.

@terrymanu terrymanu added this to the 3.1.0 milestone Oct 30, 2023
@terrymanu terrymanu changed the title Move ExecutionType to executor package Refactor error-handler modules Oct 30, 2023
@terrymanu terrymanu changed the title Refactor error-handler modules Refactor error-handler module Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Merging #2345 (6c79646) into master (f0c6852) will decrease coverage by 4.92%.
Report is 72 commits behind head on master.
The diff coverage is 83.87%.

@@             Coverage Diff              @@
##             master    #2345      +/-   ##
============================================
- Coverage     85.04%   80.12%   -4.92%     
+ Complexity     1237     1113     -124     
============================================
  Files           215      204      -11     
  Lines          3984     3824     -160     
  Branches        454      445       -9     
============================================
- Hits           3388     3064     -324     
- Misses          390      570     +180     
+ Partials        206      190      -16     
Files Coverage Δ
...hardingsphere/elasticjob/api/JobConfiguration.java 72.00% <100.00%> (ø)
...re/elasticjob/spi/listener/ElasticJobListener.java 0.00% <ø> (ø)
...lasticjob/spi/listener/param/ShardingContexts.java 10.00% <ø> (ø)
.../elasticjob/bootstrap/type/OneOffJobBootstrap.java 47.36% <ø> (ø)
...lasticjob/bootstrap/type/ScheduleJobBootstrap.java 0.00% <ø> (ø)
...lk/DingtalkJobErrorHandlerPropertiesValidator.java 100.00% <100.00%> (ø)
.../handler/dingtalk/DingtalkPropertiesConstants.java 0.00% <ø> (ø)
...cjob/error/handler/email/EmailJobErrorHandler.java 92.30% <ø> (ø)
...email/EmailJobErrorHandlerPropertiesValidator.java 100.00% <100.00%> (ø)
.../error/handler/email/EmailPropertiesConstants.java 66.66% <ø> (ø)
... and 96 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tristaZero tristaZero merged commit 0956437 into apache:master Oct 31, 2023
12 checks passed
@terrymanu terrymanu deleted the dev branch October 31, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants