-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ClassPathURLLoader cannot find files under GraalVM Native Image #30145
Conversation
7cd4056
to
53d3d4a
Compare
53d3d4a
to
79cafe4
Compare
79cafe4
to
57bb9c0
Compare
ddea6f3
to
14911d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
graalvm is too special, could it be separate with normal logic and put them into a concentrated graalvm module?
7c6b40a
to
cba4dad
Compare
|
Use |
4213283
to
19a4582
Compare
|
fface99
to
f620487
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @terrymanu Is there anything holding back the current PR from being merged? As shardingsphere refactor further, the number of JSON entries that need to be modified to fix nativeTest increases.
f620487
to
4d13571
Compare
For #30139.
Changes proposed in this pull request:
If we can't useSplit this PR from the Add GraalVM Reachability Metadata and corresponding nativeTest for Seata integration #30138 side for clarification.java.io.InputStream
in this class, then obviously we need to manually openNativeImageResourceFileSystem
under GraalVM Native Image.java.io.File
instance will break usage in both JAR(ZipFileSystemProvider
) and GraalVM Native Image(NativeImageResourceFileSystemProvider
). Refer to Callingjava.nio.file.Path#toFile
under Native Image will result injava.lang.UnsupportedOperationException
oracle/graal#7804 .java.io.File
instances via URLs likeresource:file:/resources/{entry}
orjar:file:/resources/{entry}
, because creatingjava.io.File
instances is only supported by the File System corresponding to the URL offile:/resources/{entry}
.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e
.