Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBCOMPATIBILITY 'B' parameter to opengauss database #34062

Merged
merged 38 commits into from
Dec 17, 2024

Conversation

YaoFly
Copy link
Contributor

@YaoFly YaoFly commented Dec 15, 2024

Fixes #33992.

Changes proposed in this pull request:

  • Add DBCOMPATIBILITY 'B' parameter to opengauss database

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@YaoFly YaoFly changed the title Support GroupConcat sql for aggregating multiple shards in opengauss and doris database Add DBCOMPATIBILITY 'B' parameter to opengauss database Dec 15, 2024
@YaoFly
Copy link
Contributor Author

YaoFly commented Dec 16, 2024

@strongduanmu PTAL. I have successfully run all e2e cases of opengauss locally.

@strongduanmu
Copy link
Member

Hi @YaoFly, can you add openGauss test case for group_concat? I removed it yesterday

@YaoFly
Copy link
Contributor Author

YaoFly commented Dec 16, 2024

Hi @YaoFly, can you add openGauss test case for group_concat? I removed it yesterday

Added.

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, mergd.

@strongduanmu strongduanmu merged commit a93e579 into apache:master Dec 17, 2024
135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GroupConcat sql for aggregating multiple shards in opengauss and doris database
2 participants