Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sql bind logic for create table statement and check simple table binder #34074

Merged
merged 10 commits into from
Dec 17, 2024
Merged

Add sql bind logic for create table statement and check simple table binder #34074

merged 10 commits into from
Dec 17, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Dec 16, 2024 •
edited
Loading

Ref #34029.

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@strongduanmu strongduanmu added this to the 5.5.2 milestone Dec 16, 2024
@strongduanmu
Copy link
Member Author

image

@strongduanmu strongduanmu marked this pull request as draft December 16, 2024 11:49
@strongduanmu strongduanmu marked this pull request as ready for review December 17, 2024 09:00
@strongduanmu strongduanmu marked this pull request as draft December 17, 2024 09:10
@strongduanmu strongduanmu changed the title Add sql bind logic for create table statement Add sql bind logic for create table statement and check simple table binder Dec 17, 2024
@strongduanmu strongduanmu marked this pull request as ready for review December 17, 2024 10:30
@FlyingZC FlyingZC merged commit 694c6bf into apache:master Dec 17, 2024
144 of 147 checks passed
@strongduanmu strongduanmu deleted the dev-1216 branch December 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamhucong iamhucong iamhucong approved these changes

@FlyingZC FlyingZC FlyingZC approved these changes

Assignees
No one assigned
Labels
in: SQL bind type: enhancement
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
3 participants
@strongduanmu @FlyingZC @iamhucong