Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix: Supports namespaceId.] #49

Merged
merged 1 commit into from
Nov 25, 2024
Merged

[Fix: Supports namespaceId.] #49

merged 1 commit into from
Nov 25, 2024

Conversation

koonchen
Copy link
Contributor

#48
image

@koonchen koonchen force-pushed the issue#48 branch 6 times, most recently from 8898fa8 to 651bff9 Compare November 18, 2024 05:36
@koonchen koonchen force-pushed the issue#48 branch 3 times, most recently from e74eb93 to 703bbcb Compare November 18, 2024 06:03
@koonchen
Copy link
Contributor Author

@moremind Can you run ci again? Personal project ci passed.
koonchen#2

@koonchen koonchen requested a review from moremind November 18, 2024 10:49
@lishuo5263
Copy link
Member

pls change your code,about nacos namespaceId(param named like NameSpaceId), the nacos source code is use "public"
image

@koonchen
Copy link
Contributor Author

I'm not sure if this is correct, PTAL @lishuo5263

docker-compose-consul.yml Outdated Show resolved Hide resolved
example/http_client/http_client.go Outdated Show resolved Hide resolved
example/http_client/http_client.go Outdated Show resolved Hide resolved
@koonchen koonchen changed the title [Fix: http client supports namespaceId.] (#48) [Fix: supports namespaceId.] (#48) Nov 20, 2024
@koonchen koonchen changed the title [Fix: supports namespaceId.] (#48) [Fix: Supports namespaceId.] (#48) Nov 20, 2024
@koonchen koonchen changed the title [Fix: Supports namespaceId.] (#48) [Fix: Supports namespaceId.] Nov 20, 2024
@koonchen koonchen requested a review from moremind November 20, 2024 13:58
@koonchen
Copy link
Contributor Author

@moremind PTAL

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 59 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (10938f5) to head (0ab0a0b).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
example/consul_client/consul_client.go 0.00% 21 Missing ⚠️
example/zk_client/zk_client.go 0.00% 18 Missing ⚠️
example/etcd_client/etcd_client.go 0.00% 12 Missing ⚠️
example/nacos_client/nacos_client.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main     #49    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          2       4     +2     
  Lines        186     385   +199     
======================================
- Misses       186     385   +199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@moremind moremind merged commit f6181c6 into apache:main Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants