-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-44366][BUILD] Upgrade antlr4 to 4.13.1 #43075
Conversation
Test first |
Merged to master |
Thanks @srowen |
Any idea on when this might make it into a tagged release? |
Looks like this would go out with 4.0 next year |
I noticed the Spark project uses
|
Spark 3.5 still uses antlr4 4.9.3. |
Hi, I am also facing issues with conflicts with Hibernate 6.x and Spark 3.4.1. May I know if there is any solution or workaround I can use? |
This pr is for Spark 4.x version only and it's unrelated to Spark 3.4.1. Due to the Spark 3.x releases needing to support Java 8, it also can't be backported to Spark 3.4.1. If you have other issues to discuss, you can initiate a discussion via the dev mailing list or create a related jira (even your improved patch). Thanks :) |
### What changes were proposed in this pull request? This pr is aims upgrade `antlr4` from 4.9.3 to 4.13.1 ### Why are the changes needed? After 4.10, antlr4 is using Java 11 for the source code and the compiled .class files for the ANTLR tool. There are some bug fix and Improvements after 4.9.3: - antlr/antlr4#3399 - antlr/antlr4#1105 - antlr/antlr4#2788 - antlr/antlr4#3957 - antlr/antlr4#4394 The full release notes as follows: - https://github.com/antlr/antlr4/releases/tag/4.13.1 - https://github.com/antlr/antlr4/releases/tag/4.13.0 - https://github.com/antlr/antlr4/releases/tag/4.12.0 - https://github.com/antlr/antlr4/releases/tag/4.11.1 - https://github.com/antlr/antlr4/releases/tag/4.11.0 - https://github.com/antlr/antlr4/releases/tag/4.10.1 - https://github.com/antlr/antlr4/releases/tag/4.10 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#43075 from LuciferYang/antlr4-4131. Authored-by: yangjie01 <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 13cd291)
### What changes were proposed in this pull request? This PR aims to remove an outdated `antlr4` comment in `pom.xml`. ### Why are the changes needed? This was missed when SPARK-44366 upgraded `antlr4` from 4.9.3 to 4.13.1. - #43075 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45076 from dongjoon-hyun/SPARK_ANTLR. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
This pr is aims upgrade
antlr4
from 4.9.3 to 4.13.1Why are the changes needed?
After 4.10, antlr4 is using Java 11 for the source code and the compiled .class files for the ANTLR tool. There are some bug fix and Improvements after 4.9.3:
this-escape
warning introduced in JDK 21. antlr/antlr4#4394The full release notes as follows:
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No