Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bigquery sql validator #31172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DLT1412
Copy link
Contributor

@DLT1412 DLT1412 commented Nov 27, 2024

SUMMARY

add bigquery sql validator on sqllab

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
image
after:
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • [x ] Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • [x ] Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added data:connect:googlebigquery Related to BigQuery sqllab Namespace | Anything related to the SQL Lab labels Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (76d897e) to head (b2bc549).
Report is 1094 commits behind head on master.

Files with missing lines Patch % Lines
superset/sql_validators/bigquery.py 48.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31172       +/-   ##
===========================================
+ Coverage   60.48%   83.78%   +23.30%     
===========================================
  Files        1931      537     -1394     
  Lines       76236    38957    -37279     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32642    -13472     
+ Misses      28017     6315    -21702     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.78% <50.00%> (-0.38%) ⬇️
javascript ?
mysql 76.56% <50.00%> (?)
postgres 76.62% <50.00%> (?)
presto 53.28% <50.00%> (-0.52%) ⬇️
python 83.78% <50.00%> (+20.30%) ⬆️
sqlite 76.08% <50.00%> (?)
unit 60.86% <50.00%> (+3.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadpandajoe
Copy link
Member

@DLT1412 thanks for the PR. Do you mind adding tests for this?

@sadpandajoe
Copy link
Member

We also noticed that the validation error isn't show but the request api response is shown instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect:googlebigquery Related to BigQuery size/M sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants