Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2783] Doc changes to describe the new behaviour and caveats #464

Closed
wants to merge 3 commits into from
Closed

[YUNIKORN-2783] Doc changes to describe the new behaviour and caveats #464

wants to merge 3 commits into from

Conversation

manirajv06
Copy link
Contributor

What is this PR for?

Doc changes to describe the new behaviour about queue name, user name and group names and caveats in labels.

What type of PR is it?

  • - Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2783

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@manirajv06 manirajv06 self-assigned this Aug 22, 2024
chenyulin0719
chenyulin0719 requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some incorrect descriptions.

docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
chenyulin0719
chenyulin0719 approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

ryankert01
ryankert01 reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great! some nits.

docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
pbacsko
pbacsko requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

docs/user_guide/labels_and_annotations_in_yunikorn.md Outdated Show resolved Hide resolved
docs/user_guide/labels_and_annotations_in_yunikorn.md Outdated Show resolved Hide resolved
docs/user_guide/labels_and_annotations_in_yunikorn.md Outdated Show resolved Hide resolved
docs/user_guide/placement_rules.md Outdated Show resolved Hide resolved
docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
docs/user_guide/queue_config.md Outdated Show resolved Hide resolved
ryankert01
ryankert01 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@ryankert01 ryankert01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

pbacsko
pbacsko approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manirajv06 manirajv06 closed this in 5ea6cb6 Sep 4, 2024
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@yunikorn-bot
Auto refresh: [YUNIKORN-2783] Doc changes to describe the new behavio…
bf0da65 
…ur and caveats (#464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryankert01 ryankert01 ryankert01 approved these changes

@pbacsko pbacsko pbacsko approved these changes

@wilfred-s wilfred-s Awaiting requested review from wilfred-s

@craigcondit craigcondit Awaiting requested review from craigcondit

@chenyulin0719 chenyulin0719 Awaiting requested review from chenyulin0719

Assignees

@manirajv06 manirajv06

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manirajv06 @pbacsko @chenyulin0719 @ryankert01