Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2945] Add punctuation for better clarity in Scheduler Configuration #497

Closed
wants to merge 7 commits into from

Conversation

kousei47747
Copy link

@kousei47747 kousei47747 commented Oct 24, 2024

What is this PR for?

Add punctuations for typos and better clarity.

Changes:

  1. "pre emption" >> "preemption"
  2. "user based" >> "user-based"
  3. "cluster-wide" >> "cluster wide"
  4. "In other words when the access control list of a queue does not allow access the parent queue is checked." >>
    "In other words, when the access control list of a queue does not allow access, the parent queue is checked."

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2945

Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good except for one minor point.

docs/design/scheduler_configuration.md Outdated Show resolved Hide resolved
@craigcondit craigcondit changed the title [YUNIKORN-2945] Add punctuations for typos and better clarity in Scheduler Configuration [YUNIKORN-2945] Add punctuation for better clarity in Scheduler Configuration Oct 24, 2024
@craigcondit craigcondit self-requested a review October 24, 2024 17:29
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

@kousei47747
Copy link
Author

@craigcondit thanks for reviewing!
I've removed the hyphens in preemption, please check.

Copy link
Contributor

@chenyulin0719 chenyulin0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
@chenyulin0719
Copy link
Contributor

Merged.

@kousei47747 Thanks for fixing it. Just a gentle reminder, for the next PR, please remember to cleanup the unrelated commits before submitting the new PR.

chenyulin0719 added a commit that referenced this pull request Oct 29, 2024
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
chenyulin0719 pushed a commit that referenced this pull request Oct 29, 2024
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants