-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[YUNIKORN-2946] Fix wrong indent under of yunikornDefaults in service… #498
Conversation
queues: | ||
- name: root | ||
submitacl: '*' | ||
- name: root | ||
submitacl: '*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we are using the do indent
style(Link) in other places.
So I think we should change it to below:
queues:
- name: root
submitacl: '*'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have adopted the "whatever" indenting sequences attitude. That means either indenting or not indenting individual block sequences is OK.
I personally prefer this indentation:
queues:
- name: root
submitacl: '*'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I am OK with the fix as is. It fixes the broken yaml and seems to be inline with almost all other yaml pieces we show.
@chenyulin0719 up to you if you want further changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM. I don't want to be nitpicky about it, so I'm okay with it as well. I'll merge this PR :)
…lts in service_config doc (#498)
What is this PR for?
Fix wrong indent under of yunikornDefaults in https://yunikorn.apache.org/docs/user_guide/service_config
What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2946
How should this be tested?
Screenshots (if appropriate)
Questions: