Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guidelines #14

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Add contributing guidelines #14

merged 1 commit into from
Apr 11, 2022

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 11, 2022

Starting a CONTRIBUTING.md that includes ways people can contribute to the project. This includes discussions, issues, pull requests and translations (in the future). Detailed step by step instructions on opening a Pull Request from the GitHub user interface. Lots of these were adapted from https://github.com/github/docs/blob/main/contributing/types-of-contributions.md

Addresses #9.

Starting a CONTRIBUTING.md that includes ways people can contribute to the project. This includes discussions, issues, pull requests and translations (in the future). Detailed step by step instructions on opening a Pull Request from the GitHub user interface. Lots of these were adapted from https://github.com/github/docs/blob/main/contributing/types-of-contributions.md
@weiji14 weiji14 added the documentation Improvements or additions to documentation label Apr 11, 2022
@weiji14 weiji14 self-assigned this Apr 11, 2022
@AdrienWehrle
Copy link
Contributor

Super nice work @weiji14 ! Thanks a lot! 😄

Comment on lines +39 to +51
1. [Login](https://github.com/login) to your GitHub account,
or sign up for a new one at https://github.com/signup.

2. Navigate to the file you want to modify, e.g. the
[Sentinel-2 JSON file](https://github.com/APECS-Earth-Observation/Polar-EO-Database/blob/main/data/Sentinel-2.json).

3. Click on the pen :pen: icon on the top right corner that says "Edit this file"

4. This should bring you to a page like
https://github.com/APECS-Earth-Observation/Polar-EO-Database/edit/main/data/Sentinel-2.json
where you can make edits to the text using a web-based editor.
Feel free to switch between the "Edit file" and "Preview changes" tabs as
you modify the content to make sure things look ok.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unsure on how this looks like for someone who needs to fork the repo first. @AdrienWehrle, could you use your bot account to double check if there's any extra steps needed here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to fork. The patch is created automatically on commit!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it's literally commit + PR only!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have a look at the video I sent on the slack to see how do things look like on the contributor side! 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it looks like there are some little differences in some of those points for when a new user makes a change. I'll look at your video closer and try to edit the steps later.

@weiji14 weiji14 marked this pull request as ready for review April 11, 2022 18:17
@weiji14
Copy link
Member Author

weiji14 commented Apr 11, 2022

Let's keep this PR open until after the meeting, in case anyone has any feedback.

@AdrienWehrle
Copy link
Contributor

Sounds good! 👍

@AdrienWehrle
Copy link
Contributor

I'm not sure the screen recording of the PR process would add a lot, your description is very clear and already includes screenshots! What do you think?

@weiji14
Copy link
Member Author

weiji14 commented Apr 11, 2022

I'm not sure the screen recording of the PR process would add a lot, your description is very clear and already includes screenshots! What do you think?

Still think a screen recording is good to have, people learn in different ways (video/text) so we should have both!

@AdrienWehrle
Copy link
Contributor

Ok! Let's include it in another PR!

@AdrienWehrle AdrienWehrle merged commit 025c4c7 into main Apr 11, 2022
@AdrienWehrle AdrienWehrle deleted the doc/contributing branch April 11, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants