Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sequence typer #87

Merged
merged 27 commits into from
Aug 26, 2021
Merged

Feature/sequence typer #87

merged 27 commits into from
Aug 26, 2021

Conversation

apetkau
Copy link
Owner

@apetkau apetkau commented Aug 3, 2021

  • Implements Implement a SequenceTyper #75 by adding a SequenceTyper class
  • Partially implements a method to type SARS-CoV-2 genomes by their constellations of mutations (this still has bugs which is why I named the class ExperimentalSARSCov2ConstellationsTyper).
    • On some test data I've found typing Delta and a number of other variants works properly, but B.1.1.7/Alpha does not work due to differences in naming standards of mutations (HGVS: S:p.Y145del vs. constellations: s:Y144-).
    • Plus, with the way I'm generating VCF files, some MNP mutations are split across multiple VCF lines as SNPs, which leads to incorrect predictions by snpEff for the amino acid change (this also impacts B.1.1.7).
    • However, despite all these issues, I'm still merging this in now and leaving it as an Experimental class, which can be fixed up later.

@apetkau apetkau merged commit 22eddbb into development Aug 26, 2021
@apetkau apetkau deleted the feature/sequence-typer branch August 26, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant