fix(hydra): rdfs:label should not duplicate title #6748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
reviewed
Oct 24, 2024
| @@ -99,7 +99,7 @@ private function populateEntrypointProperties(ApiResource $resourceMetadata, str | |||
| '@id' => \sprintf('#Entrypoint/%s', lcfirst($shortName)), | |||
| '@type' => $hydraPrefix.'Link', | |||
| 'domain' => '#Entrypoint', | |||
| 'rdfs:label' => "The collection of $shortName resources", | |||
| 'rdfs:label' => "get{$shortName}Collection", | |||
There was a problem hiding this comment.
Is this new value useful? Maybe can we remove it entirely.
There was a problem hiding this comment.
not sure indeed I'll check
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
soyuka
force-pushed
the
fix/hydra-fixes
branch
from
3c8659f to
fe34348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR I'm reviewing our implementation of the Hydra specification.
In regard to this work, I've added to patches to hydra-cg itself:
HydraCG/Specifications#252
HydraCG/cookbook#25