Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Revamp dredd init #1102

Merged
merged 6 commits into from
Sep 17, 2018
Merged

Revamp dredd init #1102

merged 6 commits into from
Sep 17, 2018

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Aug 10, 2018

🚀 Why this change?

  • dredd init was in terrible state, so this is a bit of love to make it better
  • CircleCI 1.0 sunset is very close

⚠️ Flaws

This is a great opportunity to add missing integration tests, but for time constraints reasons I cannot add them right now. That should not make the code worse though as there were no integration tests before the change either.

📝 Related issues and Pull Requests

✅ What didn't I forget?

  • To write docs
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

They test something already tested and they should actually test the
interplay between 'prompt' and 'applyAnswers' than the 'applyAnswers'
alone. This should be handled by integration tests in the future.
@honzajavorek honzajavorek force-pushed the honzajavorek/dredd-init branch from 7b4e7cf to 44fc8a8 Compare August 13, 2018 09:17
@honzajavorek honzajavorek requested a review from kylef August 13, 2018 09:57
jobs:
build:
docker:
- image: circleci/node:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might also be worth mentioning that apiaryio/dredd image can be used if all you need is Dredd like in your example.

In real world you will need an image capable of running Dredd alongside the users app, so I think it is worth mentioning that the circle CI images -node-browsers images adds Node to other languages, for example: circleci/python:3-node-browsers image can be used for Python apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are good points. I'm recording them here: #353 (comment)

@honzajavorek
Copy link
Contributor Author

@kylef Thank you very much for the review! ❤️

@honzajavorek honzajavorek merged commit c06bc54 into master Sep 17, 2018
@honzajavorek honzajavorek deleted the honzajavorek/dredd-init branch September 17, 2018 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants