Port CW3 to Secret #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains a large refactor to the internals of the cw3-fixed-multisig implementation to work on Secret and without cw-storage-plus as a dependency. It includes migrating from the usual Map to a similar Keymap, as well as introducing an implementation of a Binary Search Tree (based on the secret-toolkit Item implementation) to maintain ordering in state without massive, expensive sorting operations at any one time. Signed-off-by: Bobby <[email protected]>
apollo-bobby
commented
Sep 19, 2022
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
This commit fixes a bug where floating point operations were being introduced in the wasm binary, stemming from the use of the Bincode2 serilization method as default in secret-toolkit and the BST in state. Overriding the default to JSON resolves this issue. Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
apollo-bobby
commented
Nov 1, 2022
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
This commit contains large changes to enable
cw3-flex to work on Secret. This involves porting
(at least) cw4-group so that it may deployed in
conjunction with cw3-flex.
That in turn requires porting SnapshotMap from
cw-storage-plus to Secret.
Other notable changes:
* moving BinarySearchTree from cw3-fixed to this
custom storage-plus package, which SnapshotMap
is now dependent on.
* Adding a (optional) `code_hash` parameter to
ExecuteMsg::UpdateMembers.
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
|
Ready for review at this point I think. I have not ported cw4-stake, might do that later if I find the time. |
dirtyshab
requested changes
Feb 9, 2023
There was a problem hiding this comment.
nice work @apollo-bobby! most of my comments are nitpicks / cleanup reminders but I also have some clarifying questions/suggestions, please review and lmk if you have any questions/thoughts. I also have some ideas for refactoring the storage to make it easier to work with, will raise a separate PR today with that and have you review.
Signed-off-by: Bobby <[email protected]>
|
Before merging we should also update the package metadata for all crates in this repo. They all currently say by Ethan Frey in 2018 or something similar. We might also want to put our own version on them. Not saying we should discredit Ethan Frey but we probably also shouldn't credit him solely with this work. |
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Adds functionality for checking if a user is a member before allowing them to query anything in a cw3/cw4, using `Permit` from `secret-toolkit`. Contains lots of changes to dependencies due to having to upgrade `secret-toolkit` from 0.7.0 to 0.8.0. Also refactors some code in `cw3-flex-multisig and cw4-group to reduce duplicated code. `cw4-group` is now dependent on `cw3-fixed-multisig`. Signed-off-by: Bobby <[email protected]>
Signed-off-by: Bobby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains a large refactor to the internals of the cw3-fixed-multisig implementation to work on Secret and without cw-storage-plus as a dependency.
It includes migrating from the usual Map to a similar Keymap, as well as introducing an implementation of a Binary Search Tree (based on the secret-toolkit Item implementation) to maintain ordering in state without massive, expensive sorting operations at any one time.
Signed-off-by: Bobby [email protected]