Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main formatter #1

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add main formatter #1

merged 2 commits into from
Aug 21, 2024

Conversation

gondalez
Copy link
Member

@gondalez gondalez commented Aug 20, 2024

The gem is all set up but there is no content.

Add the first main class, the formatter.

Next PRs will add the config class and also the skip-if-error formatter parts.

See also https://github.com/appbot/web/pull/9926

@gondalez gondalez marked this pull request as draft August 20, 2024 09:06
@gondalez gondalez force-pushed the add-formatter branch 2 times, most recently from 949879e to 03ec8db Compare August 21, 2024 03:25
@gondalez gondalez marked this pull request as ready for review August 21, 2024 03:28
Copy link
Member Author

@gondalez gondalez Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw see spec_helper, simplecov is configured and set to enforce 100% branching coverage 😌

It is run by the github action here: https://github.com/appbot/simplecov-inline/actions/runs/10483006312/job/29034996680?pr=1

@gondalez gondalez merged commit a5a23df into main Aug 21, 2024
1 check passed
@gondalez gondalez deleted the add-formatter branch August 21, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants