Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename top matrix workflow object 'swift'->'config' #3024

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

rnro
Copy link
Contributor

@rnro rnro commented Dec 12, 2024

Motivation:

The use of 'swift' here is very arbitrary and adds no value. The object is only there at all because GitHub Actions seems to require it.

Modifications:

Rename the top-level object from 'swift' to 'config' to maybe add value to the intent of the object and hopefully be less cryptic.

Result:

Everything should just keep working.

@rnro rnro added the semver/none No version bump required. label Dec 12, 2024
@rnro rnro force-pushed the rename_matrix_workflow_object branch 2 times, most recently from 51661ce to d3b34b9 Compare December 12, 2024 10:05
@rnro
Copy link
Contributor Author

rnro commented Dec 12, 2024

Example of this change working https://github.com/apple/swift-nio/actions/runs/12294108306/job/34308220995?pr=3024

 Inputs
    name: Unit tests
    matrix_string: {"config":[{"name":"5.9","image":"swift:5.9-jammy","swift_version":"5.9","platform":"Linux","command":"swift test","command_arguments":"-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error","setup_command":"","runner":"ubuntu-latest"},{"name":"5.10","image":"swift:5.10-jammy","swift_version":"5.10","platform":"Linux","command":"swift test","command_arguments":"-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error","setup_command":"","runner":"ubuntu-latest"},{"name":"6.0","image":"swift:6.0-jammy","swift_version":"6.0","platform":"Linux","command":"swift test","command_arguments":"-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error","setup_command":"","runner":"ubuntu-latest"},{"name":"nightly-6.0","image":"swiftlang/swift:nightly-6.0-jammy","swift_version":"nightly-6.0","platform":"Linux","command":"swift test","command_arguments":"-Xswiftc -warnings-as-errors --explicit-target-dependency-import-check error","setup_command":"","runner":"ubuntu-latest"},{"name":"nightly-main","image":"swiftlang/swift:nightly-main-jammy","swift_version":"nightly-main","platform":"Linux","command":"swift test","command_arguments":"--explicit-target-dependency-import-check error","setup_command":"","runner":"ubuntu-latest"}]}
Complete job name: Unit tests / Unit tests / Linux (5.9)

Motivation:

The use of 'swift' here is very arbitrary and adds no value. The object
is only there at all because GitHub Actions seems to require it.

Modifications:

Rename the top-level object from 'swift' to 'config' to maybe add value
to the intent of the object and hopefully be less cryptic.

Result:

Everything should just keep working.
@rnro rnro force-pushed the rename_matrix_workflow_object branch from d3b34b9 to 9d10a1a Compare December 12, 2024 10:10
@rnro rnro marked this pull request as ready for review December 12, 2024 10:12
@rnro rnro requested a review from FranzBusch December 12, 2024 10:12
@rnro rnro enabled auto-merge (squash) December 12, 2024 10:21
@rnro rnro merged commit 969b06b into main Dec 13, 2024
32 of 35 checks passed
@rnro rnro deleted the rename_matrix_workflow_object branch December 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants