Remove --no-banner flag

Signed-off-by: Tamal Saha <[email protected]>
appscode-cloud · Mar 29, 2024 · 379ddcf · 379ddcf
1 parent e6929ed
commit 379ddcf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/kubectl/bind/plugin/bind.go b/pkg/kubectl/bind/plugin/bind.go
@@ -300,7 +300,7 @@ func (b *BindOptions) Run(ctx context.Context, urlCh chan<- string) error {
 
 		fmt.Fprintf(b.Options.ErrOut, "🚀 Executing: %s %s\n", "kubectl bind", strings.Join(args, " ")) // nolint: errcheck
 		fmt.Fprintf(b.Options.ErrOut, "✨ Use \"-o yaml\" and \"--dry-run\" to get the APIServiceExportRequest.\n   and pass it to \"kubectl bind apiservice\" directly. Great for automation.\n")
-		command := exec.CommandContext(ctx, executable, append(args, "--no-banner")...)
+		command := exec.CommandContext(ctx, executable, args...)
 		command.Stdin = bytes.NewReader(bs)
 		command.Stdout = b.Options.Out
 		command.Stderr = b.Options.ErrOut

diff --git a/test/e2e/bind/happy-case_test.go b/test/e2e/bind/happy-case_test.go
@@ -125,7 +125,7 @@ spec:
 				invocations := make(chan framework.SubCommandInvocation, 1)
 				framework.Bind(t, iostreams, authURLCh, invocations, fmt.Sprintf("http://%s/export", addr.String()), "--kubeconfig", consumerKubeconfig, "--skip-konnector")
 				inv := <-invocations
-				requireEqualSlicePattern(t, []string{"apiservice", "--remote-kubeconfig-namespace", "*", "--remote-kubeconfig-name", "*", "-f", "-", "--kubeconfig=" + consumerKubeconfig, "--skip-konnector=true", "--no-banner"}, inv.Args)
+				requireEqualSlicePattern(t, []string{"apiservice", "--remote-kubeconfig-namespace", "*", "--remote-kubeconfig-name", "*", "-f", "-", "--kubeconfig=" + consumerKubeconfig, "--skip-konnector=true"}, inv.Args)
 				framework.BindAPIService(t, inv.Stdin, "", inv.Args...)
 
 				t.Logf("Waiting for %s CRD to be created on consumer side", serviceGVR.Resource)
@@ -351,7 +351,7 @@ spec:
 				invocations := make(chan framework.SubCommandInvocation, 1)
 				framework.Bind(t, iostreams, authURLCh, invocations, fmt.Sprintf("http://%s/export", addr.String()), "--kubeconfig", consumerKubeconfig, "--skip-konnector")
 				inv := <-invocations
-				requireEqualSlicePattern(t, []string{"apiservice", "--remote-kubeconfig-namespace", "*", "--remote-kubeconfig-name", "*", "-f", "-", "--kubeconfig=" + consumerKubeconfig, "--skip-konnector=true", "--no-banner"}, inv.Args)
+				requireEqualSlicePattern(t, []string{"apiservice", "--remote-kubeconfig-namespace", "*", "--remote-kubeconfig-name", "*", "-f", "-", "--kubeconfig=" + consumerKubeconfig, "--skip-konnector=true"}, inv.Args)
 				framework.BindAPIService(t, inv.Stdin, "", inv.Args...)
 			},
 		},