Skip to content

Commit

Permalink
Add konnector image path and remove red banner
Browse files Browse the repository at this point in the history
Signed-off-by: rasel <[email protected]>
  • Loading branch information
Superm4n97 committed Mar 28, 2024
1 parent 77a84bc commit 5876258
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion pkg/kubectl/bind-apiservice/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func New(streams genericclioptions.IOStreams) (*cobra.Command, error) {
return err
}

if !opts.NoBanner {
if opts.Banner {
yellow := color.New(color.BgRed, color.FgBlack).SprintFunc()
fmt.Fprintf(streams.ErrOut, yellow("DISCLAIMER: This is a prototype. It will change in incompatible ways at any time.")+"\n\n") // nolint: errcheck
}
Expand Down
4 changes: 2 additions & 2 deletions pkg/kubectl/bind-apiservice/plugin/bind.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type BindAPIServiceOptions struct {
SkipKonnector bool
KonnectorImageOverride string
DowngradeKonnector bool
NoBanner bool
Banner bool

url string
}
Expand Down Expand Up @@ -90,7 +90,7 @@ func (b *BindAPIServiceOptions) AddCmdFlags(cmd *cobra.Command) {
cmd.Flags().BoolVar(&b.DowngradeKonnector, "downgrade-konnector", b.DowngradeKonnector, "Downgrade the konnector to the version of the kubectl-bind-apiservice binary")
cmd.Flags().StringVar(&b.KonnectorImageOverride, "konnector-image", b.KonnectorImageOverride, "The konnector image to use")
cmd.Flags().MarkHidden("konnector-image") // nolint:errcheck
cmd.Flags().BoolVar(&b.NoBanner, "no-banner", b.NoBanner, "Do not show the red banner")
cmd.Flags().BoolVar(&b.Banner, "no-banner", b.Banner, "Do not show the red banner")
cmd.Flags().MarkHidden("no-banner") // nolint:errcheck
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/kubectl/bind-apiservice/plugin/konnector.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import (
)

const (
konnectorImage = "ghcr.io/kube-bind/konnector"
konnectorImage = "ghcr.io/appscode/konnector"
)

// nolint: unused
Expand Down
4 changes: 0 additions & 4 deletions pkg/kubectl/bind/cmd/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import (

"go.bytebuilders.dev/kube-bind/pkg/kubectl/bind/plugin"

"github.com/fatih/color"
"github.com/spf13/cobra"
"k8s.io/cli-runtime/pkg/genericclioptions"
_ "k8s.io/client-go/plugin/pkg/client/auth/exec"
Expand Down Expand Up @@ -65,9 +64,6 @@ func New(streams genericclioptions.IOStreams) (*cobra.Command, error) {
return err
}

yellow := color.New(color.BgRed, color.FgBlack).SprintFunc()
fmt.Fprintf(streams.ErrOut, yellow("DISCLAIMER: This is a prototype. It will change in incompatible ways at any time.")+"\n\n") // nolint: errcheck

if len(args) == 0 {
return cmd.Help()
}
Expand Down

0 comments on commit 5876258

Please sign in to comment.