Add Ruby 3.4 preview 2 to the CI #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
tombruijn
force-pushed
the
ruby-3.4.0-preview2
branch
2 times, most recently
from
8bf26e0 to
6fb18f8
Compare
tombruijn
force-pushed
the
ruby-3.4.0-preview2
branch
from
edf8329 to
bb4b5eb
Compare
Test against the latest prerelease to test if any issues arise. [skip changeset] [skip review]
In Ruby 3.4 the internal representation of Hashes has changed when
called with `to_s`/`inspect`. Instead of `{:abc => :def}` it is now
`{abc: :def}`.
Use own config formatter so we are not relying on the Ruby format and
tests don't break over different Ruby versions.
In Ruby 3.4 the internal representation of Hashes has changed when
called with `to_s`/`inspect`. Instead of `{:abc => :def}` it is now
`{abc: :def}`.
Update the Data struct spec to match both formats. We don't really rely
on the String representation of Data structs so it's fine.
For the ElasticSearch event formatter it does impact how we detect
unique events. It will no longer match the event between Ruby 3.3 and
Ruby 3.4 as the same event, meaning event metrics will be restarted
after upgrading to Ruby 3.4. This is already what happens upgrading to
Ruby 3.4 with published versions of the Ruby gem. And adding our own
formatter for arbitrary search parameters seems brittle. We'd have to
keep the Ruby format prior to Ruby 3.4 too.
We generate a bunch more artifacts on Ruby 3.4 on macOS. Git ignore them so we don't accidentally commit them.
Ruby 3.4 removed a couple of standard gems. Add them manually so the tests work.
tombruijn
force-pushed
the
ruby-3.4.0-preview2
branch
from
bb4b5eb to
bfc2b5d
Compare
jeffkreeftmeijer
approved these changes
Dec 4, 2024
This is a message from the daily scheduled checks. |
luismiramirez
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ruby 3.4 preview 2 to the CI
Test against the latest prerelease to test if any issues arise.
[skip changeset]
Update Sidekiq probe config logging
In Ruby 3.4 the internal representation of Hashes has changed when called with
to_s/inspect. Instead of{:abc => :def}it is now{abc: :def}.Use own config formatter so we are not relying on the Ruby format and tests don't break over different Ruby versions.
Update Hash representation in Strings
In Ruby 3.4 the internal representation of Hashes has changed when called with
to_s/inspect. Instead of{:abc => :def}it is now{abc: :def}.Update the Data struct spec to match both formats. We don't really rely on the String representation of Data structs so it's fine.
For the ElasticSearch event formatter it does impact how we detect unique events. It will no longer match the event between Ruby 3.3 and Ruby 3.4 as the same event, meaning event metrics will be restarted after upgrading to Ruby 3.4. This is already what happens upgrading to Ruby 3.4 with published versions of the Ruby gem. And adding our own formatter for arbitrary search parameters seems brittle. We'd have to keep the Ruby format prior to Ruby 3.4 too.
Update gitignore for macOS Ruby 3.4 artifacts
We generate a bunch more artifacts on Ruby 3.4 on macOS. Git ignore them so we don't accidentally commit them.
Add required gems for tests on Ruby 3.4
Ruby 3.4 removed a couple of standard gems. Add them manually so the tests work.