Fix tagged logging push_tags for Rails 8 #1350
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 8 the `push_tags` arguments are positional, where previously it was an array of values. Support both by adding a `*` to the argument. Fixes #1348
unflxw
approved these changes
Dec 17, 2024
unflxw
added a commit
that referenced
this pull request
Dec 19, 2024
This commit removes tagged logging support from `Appsignal::Logger`, essentially reverting most of the changes in #1344, #1350, #1351 and The change to use instance variables instead of thread variables is maintained, as well as the tests that assert the expected behaviour when used alongside `ActiveSupport::TaggedLogging`, which pass notwithstanding the reverted functionality. This makes explicit in our test suite the way in which tagged logging is supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 8 the
push_tagsarguments are positional, where previously it was an array of values. Support both by adding a*to the argument.Fixes #1348