Implement logger broadcasting #1357
Open
+118
−76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the changes in #1355.
Docs need to be updated to recommend this over
Rails.logger.broadcast_to
: https://github.com/appsignal/appsignal-docs/pull/2315Implement logger broadcasting
Implement broadcasting logs to other loggers, following the same
interface as
#broadcast_to
. Unlike#broadcast_to
, however,instead of forwarding each method call one-for-one, we rely on the
#add
method which is expected of the logger interface.As such, we should not run into the kinds of bugs that affect
ActiveSupport::BroadcastLogger
when used alongside additionallogger features such as tagged logging, such as rails/rails#49745.
This enables customers to use both broadcast logging and tagged
logging with the AppSignal logger without running into
application-breaking bugs.
As a trade-off, unlike
ActiveSupport::BroadcastLogger
, ourbroadcast implementation is sensitive to the order in which those
additional features are applied, expecting them to be applied on
top of the broadcast logger, and not on the underlying loggers: