Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging initialisers to Rails 8 #245

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Add logging initialisers to Rails 8 #245

merged 1 commit into from
Dec 18, 2024

Conversation

unflxw
Copy link
Contributor

@unflxw unflxw commented Dec 17, 2024

Copy the logging initialisers for Rails and Sidekiq from the ruby/rails7-sidekiq test setup into the ruby/rails8-sidekiq test setup.

In the future, this might help us detect issues like appsignal/appsignal-ruby#1348 before they impact our customers.

Copy the logging initialisers for Rails and Sidekiq from the
`ruby/rails7-sidekiq` test setup into the `ruby/rails8-sidekiq`
test setup.

In the future, this might help us detect issues like
appsignal/appsignal-ruby#1348 before they impact our customers.
@unflxw unflxw added the chore label Dec 17, 2024
@unflxw unflxw self-assigned this Dec 17, 2024
@unflxw
Copy link
Contributor Author

unflxw commented Dec 17, 2024

Test failures seem unrelated, I'll look into them on a separate PR.

@unflxw unflxw merged commit ca1b089 into main Dec 18, 2024
1 check failed
@unflxw unflxw deleted the add-logging-to-rails-8 branch December 18, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants