Fixed a bug encountered when using nonResourcesUrl

appthrust · May 9, 2024 · 617edc3 · 617edc3
1 parent 96a7f16
commit 617edc3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/packages/kubekit-client/package.json b/packages/kubekit-client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@kubekit/client",
-  "version": "0.0.21",
+  "version": "0.0.23",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "author": "kahirokunn",

diff --git a/packages/kubekit-client/src/client/index.ts b/packages/kubekit-client/src/client/index.ts
@@ -173,7 +173,7 @@ export async function apiClient<Response>(
     ...removeNullableProperties(extraOptions),
   };
 
-  let { path, method, params, body, contentType } = { ...arguments_ };
+  let { path, method, params = {}, body, contentType } = { ...arguments_ };
 
   let httpsOptions: https.RequestOptions = {
     path,
@@ -319,9 +319,13 @@ export async function apiClient<Response>(
         return (await response.json()) as Response;
       }
 
-      // helpful message for debugging
       const text = await response.text();
+      if (isSuccess) {
+        // TODO: This is to bypass a type error, but it should be properly addressed.
+        return text as Response;
+      }
       if (response.status === 404 && text.includes('404 page not found')) {
+        // helpful message for debugging
         console.info(`Did you forget to install your Custom Resources Definitions? path: ${httpsOptions.path}`);
       }
       throw new Error(text);