Fix exe paths #34
Merged
Fix exe paths #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why the automated tests were still working, but manual testing revealed that installs did not work. According to the latest documentation, the current name of the setting is exe-path. All occurances where updated to use exe-path instead of bin-path.
This setting had no effect as it was overridden by the platform.*.exe-path settings.
There were numerous mappings in install.arch that did not actually map to something else, so these config had no effect and was only distracting. It was removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaces all install.platform.bin-path configs with ..exe-path, which is the correct setting according to the docs. This resolves #31 . I also cleaned up some redundant config which had no effect and was just misleading.