Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default organization to users that are in exactly one organization #203

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

HappyTetrahedron
Copy link
Contributor

@HappyTetrahedron HappyTetrahedron commented Feb 8, 2024

We want to add the usability feature "As a new user, I want my default organization to be set automatically when I create my first organization or accept an invitation, so that I can get started right away and don't have to worry about setup."

We simplify this to "every user who is in exactly 1 organization and does not have a default configured should have their default organization set to the one organization they are a member of". This will automatically solve the use case above both for creating your first org and for accepting your first invite.

Summary

...

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@HappyTetrahedron HappyTetrahedron added the enhancement New feature or request label Feb 8, 2024
@HappyTetrahedron HappyTetrahedron requested a review from a team as a code owner February 8, 2024 13:07
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We might need to create the user if they do not exist yet in the control api.

controllers/default_organization_controller.go Outdated Show resolved Hide resolved
We want to add the usability feature "As a user, I want my default
organization to be set automatically when I create my first organization
or accept an invitation, so that I can get started right away and don't
have to worry about setup."

We simplify this to "every user who is in exactly 1 organization and
does not have a default configured should have their default
organization set to the one organization they are a member of". This
will automatically solve the use case above both for creating your first
org and for accepting your first invite.
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

controllers/default_organization_controller_test.go Outdated Show resolved Hide resolved
@HappyTetrahedron HappyTetrahedron merged commit e4164a1 into master Feb 12, 2024
2 checks passed
@HappyTetrahedron HappyTetrahedron deleted the feat/default-org-reconcoler branch February 12, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants