Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][compiler-v2] Tests running for "move-unit-test" package are not using compiler v2 #15385

Open
vineethk opened this issue Nov 24, 2024 · 2 comments · May be fixed by #15388
Open

[Bug][compiler-v2] Tests running for "move-unit-test" package are not using compiler v2 #15385

vineethk opened this issue Nov 24, 2024 · 2 comments · May be fixed by #15388
Labels
bug Something isn't working compiler-v2

Comments

@vineethk
Copy link
Contributor

🐛 Bug

If we go to third_party/move/tools/move-unit-test and run: MVC_V2=1 MVC_BLOCK_V1=1 cargo test, we see that it panics with "V1 compiler not expected".

But the scripts/move_pr.sh runs these tests with MVC_V2=1 (i.e., the equivalent MOVE_COMPILER_V2=true); we also have baseline files *.v2_exp added with the expectation that these outputs are from running compiler v2. However, all of these actually are just running compiler v1, giving us a false sense of testing.

To reproduce

See steps above.

Expected Behavior

We should be running the tests under third_party/move/tools/move-unit-test with compiler v2 when MVC_V2=1.
@vineethk vineethk added the bug Something isn't working label Nov 24, 2024
@vineethk
Copy link
Contributor Author

cc @rahxephon89 @brmataptos: in case this was an already known issue.

@rahxephon89
Copy link
Contributor

rahxephon89 commented Nov 24, 2024 •
edited
Loading

cc @rahxephon89 @brmataptos: in case this was an already known issue.

Good catch @vineethk! We should use plan_builder_v2 when V2 flag is turned on. cc @brmataptos

@brmataptos brmataptos moved this from 🆕 New to For Grabs in Move Language and Runtime Nov 24, 2024
@rahxephon89 rahxephon89 linked a pull request Nov 25, 2024 that will close this issue
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler-v2
Projects
Move Language and Runtime
Status: For Grabs
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Compiler-v2] Fix test plan in move-unit-test to use compiler v2 aptos-labs/aptos-core
2 participants
@vineethk @rahxephon89