[Compiler-v2] Fix test plan in move-unit-test to use compiler v2 #15388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 33m total CI duration on this PR
|
rahxephon89
force-pushed
the
teng/fix-15385
branch
from
80986e1
to
4f904cb
Compare
rahxephon89
changed the title
rahxephon89
changed the title
rahxephon89
requested review from
davidiw,
movekevin and
wrwg
as code owners
vineethk
approved these changes
Nov 25, 2024
| │ │ | ||
| │ 36 │ fun test_doesnt_exist() { | ||
| │ │ ----------------- In this function in 0x1::M | ||
| │ · | ||
| │ 47 │ abort 0 | ||
| │ │ ^^^^^^^ Test was not expected to error, but it aborted with code 0 originating in the module 0000000000000000000000000000000000000000000000000000000000000001::M rooted here | ||
| │ 43 │ i = i + 1; |
There was a problem hiding this comment.
I am guessing this is because of peephole as well, if we can get this PR merged in, I can rebase and further validate the peephole locations fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #15385 by explicitly using test plan builder v2 in
move-unit-testwhenMOVE_COMPILER_V2is set to true.How Has This Been Tested?
Existing test cases in
move-unit-test, see updated baseline files.Key Areas to Review
Whether flags are correctly set when running tests using Compiler v2.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist