Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission check to account #14535

Draft
wants to merge 1 commit into
base: asset_permission
Choose a base branch
from
Draft

Add permission check to account #14535

wants to merge 1 commit into from
+70 −21

Conversation

runtian-zhou
Copy link
Contributor

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@trunk-io Trunk.io
Copy link

trunk-io bot commented Sep 5, 2024 •
edited
Loading

⏱️ 3h 3m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-move-unit-coverage 20m 🟩 
rust-move-unit-coverage 19m 🟩 
rust-move-unit-coverage 16m 🟩 
rust-move-unit-coverage 15m 🟩 
rust-move-unit-coverage 14m 🟩 
general-lints 13m 🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-cargo-deny 12m 🟩 🟩 🟩 🟩 🟩 (+2 more)
rust-move-unit-coverage 11m 🟩 
check-dynamic-deps 9m 🟩 🟩 🟩 🟩 🟩 (+3 more)
rust-move-tests 9m 🟥 
rust-move-tests 8m 🟥 
rust-move-tests 8m 🟥 
rust-move-tests 8m 🟥 
rust-move-unit-coverage 3m ⬜ 
semgrep/ci 3m 🟩 🟩 🟩 🟩 🟩 (+2 more)

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@runtian-zhou Graphite App
Copy link
Contributor Author

runtian-zhou commented Sep 5, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 703921b to 48991ff Compare September 9, 2024 07:08
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 05cd155 to 19324d8 Compare September 9, 2024 07:08
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (asset_permission@444ac11). Learn more about missing BASE report.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##             asset_permission   #14535   +/-   ##
===================================================
  Coverage                    ?    59.4%           
===================================================
  Files                       ?      857           
  Lines                       ?   210762           
  Branches                    ?        0           
===================================================
  Hits                        ?   125197           
  Misses                      ?    85565           
  Partials                    ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 48991ff to 906c7c7 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 19324d8 to 0a93383 Compare September 9, 2024 07:47
@runtian-zhou runtian-zhou force-pushed the 09-04-implement_rust_logics_for_permissioned_signer branch from 906c7c7 to 350db4c Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou mentioned this pull request Sep 9, 2024
Draft
21 tasks
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 0a93383 to bde486a Compare September 9, 2024 17:09
@runtian-zhou runtian-zhou changed the base branch from 09-04-implement_rust_logics_for_permissioned_signer to asset_permission September 9, 2024 17:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from bde486a to 5fc08ad Compare September 9, 2024 17:55
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 5fc08ad to da28781 Compare September 10, 2024 17:25
@runtian-zhou runtian-zhou mentioned this pull request Sep 10, 2024
Draft
21 tasks
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from da28781 to 006ad4c Compare September 10, 2024 17:29
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 006ad4c to ef7abd3 Compare September 12, 2024 01:50
This was referenced Sep 12, 2024
Draft
Draft
Open
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from ef7abd3 to c38c2dd Compare September 17, 2024 05:09
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from c38c2dd to 95b6704 Compare September 17, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 95b6704 to 7394967 Compare September 18, 2024 06:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 47e6977 to 8c769d8 Compare November 18, 2024 21:55
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 8c769d8 to 4a6a3b8 Compare November 18, 2024 22:00
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 4a6a3b8 to dd5f835 Compare November 18, 2024 22:18
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from dd5f835 to 79d54d6 Compare November 19, 2024 18:12
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 79d54d6 to 27f0fc8 Compare November 19, 2024 18:39
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 27f0fc8 to 23fff63 Compare November 19, 2024 19:24
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 23fff63 to f9a83e7 Compare November 19, 2024 21:23
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from f9a83e7 to 07cad53 Compare November 20, 2024 20:25
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 07cad53 to ec2c261 Compare November 20, 2024 21:02
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from ec2c261 to 6bddfa8 Compare November 21, 2024 18:01
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 6bddfa8 to 7754575 Compare November 22, 2024 08:06
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 7754575 to 2bd6008 Compare November 22, 2024 08:47
@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 2bd6008 to 1c1bb56 Compare November 22, 2024 21:30
rahxephon89
rahxephon89 reviewed Nov 24, 2024
View reviewed changes
aptos-move/framework/aptos-framework/sources/account.move
@@ -357,6 +359,7 @@ module aptos_framework::account {
) acquires Account, OriginatingAddress {
let addr = signer::address_of(account);
assert!(exists_at(addr), error::not_found(EACCOUNT_DOES_NOT_EXIST));
permissioned_signer::assert_master_signer(account);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain here or add a doc in the PR description on when this assert is needed in the account module.

@runtian-zhou runtian-zhou force-pushed the 09-04-add_permission_check_to_account branch from 1c1bb56 to efd81cc Compare November 25, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahxephon89 rahxephon89 rahxephon89 left review comments

@junkil-park junkil-park Awaiting requested review from junkil-park junkil-park will be requested when the pull request is marked ready for review junkil-park is a code owner

@alinush alinush Awaiting requested review from alinush alinush will be requested when the pull request is marked ready for review alinush is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runtian-zhou @rahxephon89