Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[single node benchmark] recalibrate and make thresholds depend on number samples present #15049

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Oct 22, 2024

⏱️ 5h 14m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 53m 🟩🟩🟩🟩🟩
rust-smoke-tests 1h 7m 🟥🟥
execution-performance / test-target-determinator 16m 🟩🟩🟩🟩🟩
test-target-determinator 16m 🟩🟩🟩🟩 (+1 more)
forge-compat-test / forge 14m 🟩
check 11m 🟩🟩
rust-move-tests 10m 🟩
rust-cargo-deny 9m 🟩🟩🟩🟩🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
check-dynamic-deps 6m 🟩🟩🟩🟩🟩 (+1 more)
rust-doc-tests 6m 🟩
fetch-last-released-docker-image-tag 6m 🟩🟩🟩
rust-doc-tests 5m 🟩
rust-move-tests 3m

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@msmouse msmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks boss

@igor-aptos igor-aptos added the CICD:run-execution-performance-test Run execution performance test label Oct 22, 2024
@igor-aptos igor-aptos force-pushed the igor/recalibrate_and_expand_range branch from 9bd3af1 to 515626a Compare October 22, 2024 23:13
@igor-aptos igor-aptos force-pushed the igor/recalibrate_and_expand_range branch from 515626a to 7b14e11 Compare October 22, 2024 23:20
@igor-aptos igor-aptos enabled auto-merge (rebase) October 22, 2024 23:20

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos force-pushed the igor/recalibrate_and_expand_range branch from 7b14e11 to c4a7e59 Compare October 23, 2024 16:32
@igor-aptos igor-aptos force-pushed the igor/recalibrate_and_expand_range branch from c4a7e59 to 25f7009 Compare October 23, 2024 16:36

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 25f70099f4b4fde99455f13506be623a1cfb06eb

two traffics test: inner traffic : committed: 14198.99 txn/s, latency: 2805.60 ms, (p50: 2400 ms, p70: 2400, p90: 2800 ms, p99: 11800 ms), latency samples: 5398760
two traffics test : committed: 99.98 txn/s, latency: 2192.14 ms, (p50: 1400 ms, p70: 1500, p90: 4700 ms, p99: 11800 ms), latency samples: 1820
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.648, avg: 1.214", "ConsensusProposalToOrdered: max: 0.317, avg: 0.294", "ConsensusOrderedToCommit: max: 0.387, avg: 0.374", "ConsensusProposalToCommit: max: 0.678, avg: 0.668"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.15s no progress at version 39496 (avg 0.21s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.54s no progress at version 2549370 (avg 8.54s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb (PR)
Upgrade the nodes to version: 25f70099f4b4fde99455f13506be623a1cfb06eb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1136.10 txn/s, submitted: 1139.68 txn/s, failed submission: 3.58 txn/s, expired: 3.58 txn/s, latency: 2651.97 ms, (p50: 2600 ms, p70: 2800, p90: 3700 ms, p99: 5100 ms), latency samples: 101640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1043.91 txn/s, submitted: 1045.88 txn/s, failed submission: 1.97 txn/s, expired: 1.97 txn/s, latency: 2849.54 ms, (p50: 2400 ms, p70: 3100, p90: 4800 ms, p99: 7000 ms), latency samples: 95360
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb passed
Upgrade the remaining nodes to version: 25f70099f4b4fde99455f13506be623a1cfb06eb
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1196.99 txn/s, submitted: 1200.36 txn/s, failed submission: 3.37 txn/s, expired: 3.37 txn/s, latency: 2535.24 ms, (p50: 2200 ms, p70: 2700, p90: 4000 ms, p99: 6100 ms), latency samples: 106640
Test Ok

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb

Compatibility test results for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb (PR)
1. Check liveness of validators at old version: b29f09f57e898d8d211c8bc3e303f6e50bba2266
compatibility::simple-validator-upgrade::liveness-check : committed: 15341.86 txn/s, latency: 2224.76 ms, (p50: 2000 ms, p70: 2100, p90: 2400 ms, p99: 5800 ms), latency samples: 490040
2. Upgrading first Validator to new version: 25f70099f4b4fde99455f13506be623a1cfb06eb
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7050.63 txn/s, latency: 3980.60 ms, (p50: 4200 ms, p70: 4500, p90: 5200 ms, p99: 5500 ms), latency samples: 134020
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6881.35 txn/s, latency: 4728.94 ms, (p50: 5000 ms, p70: 5200, p90: 6000 ms, p99: 6800 ms), latency samples: 236280
3. Upgrading rest of first batch to new version: 25f70099f4b4fde99455f13506be623a1cfb06eb
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6013.74 txn/s, latency: 4670.07 ms, (p50: 5300 ms, p70: 5500, p90: 5800 ms, p99: 6100 ms), latency samples: 113840
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5886.55 txn/s, latency: 5178.38 ms, (p50: 5500 ms, p70: 5700, p90: 7200 ms, p99: 7700 ms), latency samples: 226880
4. upgrading second batch to new version: 25f70099f4b4fde99455f13506be623a1cfb06eb
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 8242.71 txn/s, latency: 3345.94 ms, (p50: 3700 ms, p70: 4000, p90: 4900 ms, p99: 5200 ms), latency samples: 144640
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8000.76 txn/s, latency: 3960.63 ms, (p50: 4000 ms, p70: 4300, p90: 5900 ms, p99: 6300 ms), latency samples: 260480
5. check swarm health
Compatibility test for b29f09f57e898d8d211c8bc3e303f6e50bba2266 ==> 25f70099f4b4fde99455f13506be623a1cfb06eb passed
Test Ok

@igor-aptos igor-aptos merged commit bf3e91c into main Oct 23, 2024
45 of 48 checks passed
@igor-aptos igor-aptos deleted the igor/recalibrate_and_expand_range branch October 23, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants