-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loader-v2] Refactor how environment is stored in unsync storages and remove V1 from tests #15280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 4h 6m total CI duration on this PR
|
9 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 14, 2024 21:45
81c6911
to
2fc9376
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 14, 2024 21:45
f706417
to
9c04cda
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 14, 2024 21:52
2fc9376
to
b0be60f
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 14, 2024 21:52
9c04cda
to
edfde26
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 14, 2024 21:53
b0be60f
to
9d0662e
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 14, 2024 21:53
edfde26
to
90332d4
Compare
georgemitenkov
changed the title
Loader V2 refactoring: - Unify imports - Move environment from storages into ModuleBytesStorages - Move unsync code storage implementation tests - Remove V1 loader test flows
[loader-v2] Refactor how environment is stored in unsync storages and remove V1 from tests
Nov 14, 2024
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 14, 2024 22:11
90332d4
to
9d7c430
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 15, 2024 12:23
9d0662e
to
7a6c5d8
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 15, 2024 12:23
9d7c430
to
824edba
Compare
22 tasks
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
5 times, most recently
from
November 15, 2024 15:30
1c23787
to
cd35e7d
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 16, 2024 23:29
7a6c5d8
to
ff000e6
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 16, 2024 23:30
cd35e7d
to
8e33613
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 16, 2024 23:34
ff000e6
to
b4bdd07
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 16, 2024 23:35
8e33613
to
196744a
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 17, 2024 23:00
b4bdd07
to
74e7b8e
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 17, 2024 23:00
196744a
to
e7aa428
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 19, 2024 14:15
74e7b8e
to
c8baef0
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
2 times, most recently
from
November 19, 2024 14:22
01c6a08
to
f4e1b3f
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 19, 2024 14:23
f865dff
to
70136fa
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 19, 2024 14:23
f4e1b3f
to
d7a48ca
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 19, 2024 14:26
70136fa
to
34ebfc0
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 19, 2024 14:26
d7a48ca
to
dec3616
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 19, 2024 14:37
34ebfc0
to
2b41a15
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 19, 2024 14:37
dec3616
to
1b784b4
Compare
- Unify imports - Move environment from storages into ModuleBytesStorages - Move unsync code storage implementation tests - Remove V1 loader test flows
georgemitenkov
force-pushed
the
george/loader-v2-todos
branch
from
November 19, 2024 15:39
2b41a15
to
e46a83a
Compare
georgemitenkov
force-pushed
the
george/loader-v2-todos-2
branch
from
November 19, 2024 15:40
1b784b4
to
fae1284
Compare
Breaking PR into multiple |
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors
UnsyncModuleStorage
andUnsyncCodeStorage
so that they do not own the runtime environment. The goal is to make them stateless, which would allow us to get rid of clones andArc
s forAptosEnvironment
. Currently, this is tricky to do because storages consume the environment clone.On this PR:
InMemoryStorage
to also store environment. This is helpful because it allows to store deserializer config inside, which is needed anyway. This way storage interfaces are unified: adapter, Block-STM's latest view and this - all store a reference to some bytes + environment.StateViewAdapter
to also store environment.Unsync...Storage
s because now it is provided by the trait bound onS: ... + WithRuntimeEnvironment
. This way we do not need to own it there. Moved tests tointegration-tests/code_storage_tests.rs
.Bonus: as loader V2 is default, removed legacy V1 flows. For
loader_tests.rs
inintegration-tests
I think we can remove some (cc @vgao1996) because size check is removed. For concurrent tests, will bring them back separately (tracked as a TODO).How Has This Been Tested?
Existing tests, this PR just moves some code around.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist