-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker] use cloudfront debian mirrors for bullseye #15303
Conversation
This should improve build time and reliability Test Plan: build images
⏱️ 5h 40m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
docker/builder/tools.Dockerfile
Outdated
# TODO upgrade to bookworm | ||
RUN echo "deb https://cloudfront.debian.net/debian/ bullseye main" > /etc/apt/sources.list.d/bullseye.list && \ | ||
echo "Package: *\nPin: release n=bullseye\nPin-Priority: 50" > /etc/apt/preferences.d/bullseye |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title and TODO suggest upgrading to bookworm, but the code still configures bullseye
as the debian repository and pin. To complete the upgrade, replace both instances of bullseye
with bookworm
in the repository URL and pin configuration.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
290121d
to
21c4558
Compare
78ae46a
to
dcfbd5a
Compare
7bb19c4
to
a48f83f
Compare
a48f83f
to
1b640ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land it to unblock. I will work on it later to pull a base image instead of building it during cache invalidations.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* [builder] Point docker builds to aws hosted cloudfront mirror This should improve build time and reliability Test Plan: build images * [docker] use cloudfront debian mirrors for bullseye * [docker] debian-base install * [docker] cleanup stuff into debian-base --------- Co-authored-by: Perry Randall <[email protected]> (cherry picked from commit 7cf7637)
* [builder] Point docker builds to aws hosted cloudfront mirror This should improve build time and reliability Test Plan: build images * [docker] use cloudfront debian mirrors for bullseye * [docker] debian-base install * [docker] cleanup stuff into debian-base --------- Co-authored-by: Perry Randall <[email protected]> (cherry picked from commit 7cf7637)
* [builder] Point docker builds to aws hosted cloudfront mirror This should improve build time and reliability Test Plan: build images * [docker] use cloudfront debian mirrors for bullseye * [docker] debian-base install * [docker] cleanup stuff into debian-base --------- Co-authored-by: Perry Randall <[email protected]> (cherry picked from commit 7cf7637)
💔 Some backports could not be created
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
* [builder] Point docker builds to aws hosted cloudfront mirror This should improve build time and reliability Test Plan: build images * [docker] use cloudfront debian mirrors for bullseye * [docker] debian-base install * [docker] cleanup stuff into debian-base --------- Co-authored-by: Perry Randall <[email protected]> (cherry picked from commit 7cf7637)
Description
commandeer #15230 for debian bullseye
/etc/apt/sources.list
directly viased
during thedebian-base
andrust-base
images builddebian-base
image to prevent re-install in each leaf buildHow Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist