Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler-v2] Test case reduced from move-stdlib showing opportunity for optimization #15338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Nov 20, 2024

Description

Adds a test case to support the description in the issue: #15339.

This test case was reduced from a function (vector::reverse_append) in move stdlib.

How Has This Been Tested?

Test added.

Copy link

trunk-io bot commented Nov 20, 2024

⏱️ 1h 48m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 23m 🟩
rust-move-tests 13m 🟩
rust-move-tests 13m 🟩
rust-move-tests 12m 🟩
rust-move-tests 8m
check-dynamic-deps 8m 🟩🟩🟩🟩🟩
rust-cargo-deny 7m 🟩🟩🟩🟩
rust-doc-tests 5m 🟩
test-target-determinator 5m 🟩
execution-performance / test-target-determinator 5m 🟩
check 4m 🟩
semgrep/ci 2m 🟩🟩🟩🟩🟩
general-lints 2m 🟩🟩🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
file_change_determinator 46s 🟩🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk force-pushed the vk/move-stdlib-reduced-testcase branch from 5790c33 to 7e7eae7 Compare November 20, 2024 21:51
@vineethk vineethk force-pushed the vk/move-stdlib-reduced-testcase branch from 7e7eae7 to 2e628e0 Compare November 22, 2024 13:37
@vineethk vineethk marked this pull request as ready for review November 22, 2024 13:39
@vineethk vineethk enabled auto-merge (squash) November 25, 2024 18:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

two traffics test: inner traffic : committed: 13900.97 txn/s, latency: 2857.07 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5285560
two traffics test : committed: 99.96 txn/s, latency: 1824.10 ms, (p50: 1600 ms, p70: 1900, p90: 2200 ms, p99: 8500 ms), latency samples: 1860
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.396, avg: 1.444", "ConsensusProposalToOrdered: max: 0.336, avg: 0.297", "ConsensusOrderedToCommit: max: 0.381, avg: 0.368", "ConsensusProposalToCommit: max: 0.680, avg: 0.665"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 2868246 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.36s no progress at version 2868244 (avg 15.36s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 (PR)
Upgrade the nodes to version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1364.34 txn/s, submitted: 1367.06 txn/s, failed submission: 2.71 txn/s, expired: 2.71 txn/s, latency: 2251.34 ms, (p50: 2100 ms, p70: 2400, p90: 3600 ms, p99: 5100 ms), latency samples: 120640
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1333.14 txn/s, submitted: 1335.42 txn/s, failed submission: 2.28 txn/s, expired: 2.28 txn/s, latency: 2300.72 ms, (p50: 2100 ms, p70: 2400, p90: 3300 ms, p99: 5200 ms), latency samples: 116720
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 passed
Upgrade the remaining nodes to version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1369.24 txn/s, submitted: 1371.91 txn/s, failed submission: 2.67 txn/s, expired: 2.67 txn/s, latency: 2267.58 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5200 ms), latency samples: 122960
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40

Compatibility test results for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 (PR)
1. Check liveness of validators at old version: 94976266c0e4edd1a31a3783be4c4184f8892ff5
compatibility::simple-validator-upgrade::liveness-check : committed: 10359.66 txn/s, latency: 2466.64 ms, (p50: 1800 ms, p70: 1900, p90: 2700 ms, p99: 33600 ms), latency samples: 483500
2. Upgrading first Validator to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4350.53 txn/s, latency: 6770.66 ms, (p50: 7300 ms, p70: 8100, p90: 8300 ms, p99: 8500 ms), latency samples: 93680
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4470.92 txn/s, latency: 7328.29 ms, (p50: 7700 ms, p70: 8200, p90: 8700 ms, p99: 9700 ms), latency samples: 166200
3. Upgrading rest of first batch to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 1301.36 txn/s, latency: 17640.31 ms, (p50: 19200 ms, p70: 25400, p90: 28200 ms, p99: 29300 ms), latency samples: 55440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5761.29 txn/s, latency: 5633.09 ms, (p50: 4600 ms, p70: 5500, p90: 11000 ms, p99: 11600 ms), latency samples: 194280
4. upgrading second batch to new version: bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9855.83 txn/s, latency: 2742.31 ms, (p50: 2200 ms, p70: 3400, p90: 4600 ms, p99: 5500 ms), latency samples: 175960
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9061.07 txn/s, latency: 3406.57 ms, (p50: 2500 ms, p70: 4500, p90: 5600 ms, p99: 7400 ms), latency samples: 300320
5. check swarm health
Compatibility test for 94976266c0e4edd1a31a3783be4c4184f8892ff5 ==> bf6fb60433eac3c248c7f86ea5ff4a3a861e3d40 passed
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants