Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cp][aptos-release-v1.23] [consensus] sync improvements to help slow nodes sync better #15376

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2024

Backport

This will backport the following commits from main to aptos-release-v1.23:

Questions ?

Please refer to the Backport tool documentation

* [qs] grace period before GC committed batches

* [consensus] trigger sync based on remote LI timestamp

(cherry picked from commit d672085)
Copy link

trunk-io bot commented Nov 22, 2024

⏱️ 3h 22m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-unit-tests 1h 5m 🟥🟥🟩
execution-performance / single-node-performance 50m 🟩🟩
rust-unit-tests 22m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
test-target-determinator 9m 🟩🟩
execution-performance / test-target-determinator 8m 🟩🟩
check 7m 🟩🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
rust-cargo-deny 4m 🟩🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩
general-lints 2m 🟩🟩
semgrep/ci 58s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@ibalajiarun ibalajiarun enabled auto-merge (squash) November 22, 2024 22:26

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

✅ Forge suite realistic_env_max_load success on a602995343928a6b0d98b2a7dcdf90b2fea46d27

two traffics test: inner traffic : committed: 14010.04 txn/s, latency: 2836.90 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 6300 ms), latency samples: 5326880
two traffics test : committed: 99.89 txn/s, latency: 1412.43 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 3200 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.533, avg: 1.634", "ConsensusProposalToOrdered: max: 0.322, avg: 0.294", "ConsensusOrderedToCommit: max: 0.372, avg: 0.361", "ConsensusProposalToCommit: max: 0.666, avg: 0.655"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.98s no progress at version 25900 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 15.81s no progress at version 2470492 (avg 15.81s) [limit 16].
Test Ok

Copy link
Contributor Author

✅ Forge suite compat success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27 (PR)
1. Check liveness of validators at old version: afa8d75c467820b7d96bbe13ab0d011c12f8b3a3
compatibility::simple-validator-upgrade::liveness-check : committed: 17109.89 txn/s, latency: 1994.65 ms, (p50: 2100 ms, p70: 2100, p90: 2200 ms, p99: 2600 ms), latency samples: 549960
2. Upgrading first Validator to new version: a602995343928a6b0d98b2a7dcdf90b2fea46d27
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7945.36 txn/s, latency: 3584.17 ms, (p50: 4000 ms, p70: 4200, p90: 4300 ms, p99: 4400 ms), latency samples: 147600
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7859.70 txn/s, latency: 4066.79 ms, (p50: 4300 ms, p70: 4400, p90: 5700 ms, p99: 6000 ms), latency samples: 260160
3. Upgrading rest of first batch to new version: a602995343928a6b0d98b2a7dcdf90b2fea46d27
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7310.67 txn/s, latency: 3765.78 ms, (p50: 4100 ms, p70: 4300, p90: 5000 ms, p99: 5100 ms), latency samples: 137080
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7768.77 txn/s, latency: 4109.54 ms, (p50: 4200 ms, p70: 4300, p90: 6300 ms, p99: 6600 ms), latency samples: 258200
4. upgrading second batch to new version: a602995343928a6b0d98b2a7dcdf90b2fea46d27
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12248.51 txn/s, latency: 2261.48 ms, (p50: 2500 ms, p70: 2600, p90: 2700 ms, p99: 2800 ms), latency samples: 212460
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 12174.26 txn/s, latency: 2635.26 ms, (p50: 2600 ms, p70: 2700, p90: 2800 ms, p99: 3400 ms), latency samples: 394480
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27 passed
Test Ok

Copy link
Contributor Author

✅ Forge suite framework_upgrade success on afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27

Compatibility test results for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27 (PR)
Upgrade the nodes to version: a602995343928a6b0d98b2a7dcdf90b2fea46d27
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1226.92 txn/s, submitted: 1229.57 txn/s, failed submission: 2.65 txn/s, expired: 2.65 txn/s, latency: 2577.67 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5700 ms), latency samples: 111080
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1400.06 txn/s, submitted: 1403.24 txn/s, failed submission: 3.18 txn/s, expired: 3.18 txn/s, latency: 2188.83 ms, (p50: 2100 ms, p70: 2100, p90: 3400 ms, p99: 4300 ms), latency samples: 123280
5. check swarm health
Compatibility test for afa8d75c467820b7d96bbe13ab0d011c12f8b3a3 ==> a602995343928a6b0d98b2a7dcdf90b2fea46d27 passed
Upgrade the remaining nodes to version: a602995343928a6b0d98b2a7dcdf90b2fea46d27
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1354.26 txn/s, submitted: 1358.01 txn/s, failed submission: 3.75 txn/s, expired: 3.75 txn/s, latency: 2177.73 ms, (p50: 1800 ms, p70: 2100, p90: 3400 ms, p99: 5100 ms), latency samples: 122740
Test Ok

@ibalajiarun ibalajiarun merged commit 6a40015 into aptos-release-v1.23 Nov 23, 2024
45 of 48 checks passed
@ibalajiarun ibalajiarun deleted the backport/aptos-release-v1.23/pr-15364 branch November 23, 2024 16:12
Copy link

trunk-io bot commented Nov 23, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants