Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: restructure between state related types #15378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msmouse
Copy link
Contributor

@msmouse msmouse commented Nov 22, 2024

Description

regroup things
move things out from aptos-types to aptos-storage-interface
remove unused things

How Has This Been Tested?

existing coverage

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Validator Node

Copy link

trunk-io bot commented Nov 22, 2024

@msmouse msmouse added the CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR label Nov 22, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@msmouse msmouse enabled auto-merge (squash) November 23, 2024 00:16

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on b3b0d83ddb4754736ed5d1a770f70af9b29e350e

two traffics test: inner traffic : committed: 14400.35 txn/s, latency: 2757.49 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5475340
two traffics test : committed: 100.03 txn/s, latency: 1488.84 ms, (p50: 1400 ms, p70: 1500, p90: 1500 ms, p99: 5300 ms), latency samples: 1840
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.966, avg: 1.562", "ConsensusProposalToOrdered: max: 0.318, avg: 0.292", "ConsensusOrderedToCommit: max: 0.378, avg: 0.364", "ConsensusProposalToCommit: max: 0.669, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.20s no progress at version 2822712 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.45s no progress at version 2822710 (avg 8.45s) [limit 15].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e (PR)
1. Check liveness of validators at old version: 327445f70a3b9474f13a792e8ada9b85809dec86
compatibility::simple-validator-upgrade::liveness-check : committed: 16488.02 txn/s, latency: 2046.76 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 2700 ms), latency samples: 534300
2. Upgrading first Validator to new version: b3b0d83ddb4754736ed5d1a770f70af9b29e350e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 6889.70 txn/s, latency: 4182.03 ms, (p50: 4700 ms, p70: 4900, p90: 5200 ms, p99: 5200 ms), latency samples: 126840
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 6929.05 txn/s, latency: 4660.80 ms, (p50: 5000 ms, p70: 5200, p90: 6100 ms, p99: 6500 ms), latency samples: 238360
3. Upgrading rest of first batch to new version: b3b0d83ddb4754736ed5d1a770f70af9b29e350e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6652.96 txn/s, latency: 4298.33 ms, (p50: 5000 ms, p70: 5200, p90: 5300 ms, p99: 5400 ms), latency samples: 122220
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 6056.40 txn/s, latency: 5449.38 ms, (p50: 5900 ms, p70: 6100, p90: 6200 ms, p99: 6300 ms), latency samples: 200240
4. upgrading second batch to new version: b3b0d83ddb4754736ed5d1a770f70af9b29e350e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 11703.31 txn/s, latency: 2346.19 ms, (p50: 2500 ms, p70: 2800, p90: 2900 ms, p99: 3200 ms), latency samples: 201500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 11117.92 txn/s, latency: 2829.74 ms, (p50: 2600 ms, p70: 2700, p90: 5100 ms, p99: 6100 ms), latency samples: 357840
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e passed
Test Ok

Copy link
Contributor

✅ Forge suite framework_upgrade success on 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e

Compatibility test results for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e (PR)
Upgrade the nodes to version: b3b0d83ddb4754736ed5d1a770f70af9b29e350e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1341.24 txn/s, submitted: 1343.69 txn/s, failed submission: 2.46 txn/s, expired: 2.46 txn/s, latency: 2349.39 ms, (p50: 2100 ms, p70: 2400, p90: 3900 ms, p99: 5600 ms), latency samples: 119980
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1377.22 txn/s, submitted: 1380.57 txn/s, failed submission: 3.35 txn/s, expired: 3.35 txn/s, latency: 2195.05 ms, (p50: 2100 ms, p70: 2400, p90: 3500 ms, p99: 6000 ms), latency samples: 123400
5. check swarm health
Compatibility test for 327445f70a3b9474f13a792e8ada9b85809dec86 ==> b3b0d83ddb4754736ed5d1a770f70af9b29e350e passed
Upgrade the remaining nodes to version: b3b0d83ddb4754736ed5d1a770f70af9b29e350e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1381.94 txn/s, submitted: 1383.74 txn/s, failed submission: 1.80 txn/s, expired: 1.80 txn/s, latency: 2381.72 ms, (p50: 2100 ms, p70: 2600, p90: 4200 ms, p99: 5700 ms), latency samples: 122600
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-e2e-tests when this label is present github actions will run all land-blocking e2e tests from the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants