Fix units in timed feature flags #15391
Open
+94
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 30m total CI duration on this PR
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
vineethk
force-pushed
the
vk/timed_feature_flags_fix
branch
from
7b9d699
to
1d9b5b7
Compare
vineethk
requested review from
runtian-zhou,
rahxephon89,
vgao1996,
georgemitenkov and
zekun000
brmataptos
approved these changes
Nov 25, 2024
rahxephon89
approved these changes
Nov 25, 2024
georgemitenkov
approved these changes
Nov 25, 2024
| @@ -161,4 +160,86 @@ mod test { | |||
| let testing = assert_ok!(bcs::to_bytes(&TimedFeatureOverride::Testing)); | |||
| assert_ne!(replay, testing); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_timed_features_activation() { | |||
There was a problem hiding this comment.
Thank you for adding tests 👍
| @@ -84,6 +82,7 @@ pub struct TimedFeaturesBuilder { | |||
| } | |||
|
|
|||
| impl TimedFeaturesBuilder { | |||
| /// `timestamp` is a Unix Epoch timestamp in microseconds. | |||
| pub fn new(chain_id: ChainId, timestamp: u64) -> Self { | |||
There was a problem hiding this comment.
This is probably super nit, but i think you can define a type alias pub type Micros = u64. Then all callers of new(...) have to cast (and therefore think about units)?
another nit: timestamp_micros?
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, timed feature flags activation time used millis as the unit,
last_reconfiguration_timeused micros as the unit, and these two were compared to see if timed feature flag was enabled (which was always true for any date on which blockchain has been around).DisableInvariantViolationCheckInSwapLoc(keeping the same semantics as before, but applying a minor fix).EntryCompatibility(as there are transactions on mainnet before this feature was activated that fail the corresponding check).How Has This Been Tested?
Type of Change
Which Components or Systems Does This Change Impact?